Better performance for KALES19 and KISS17 NR-OPRFS.

pvriel · pvriel · commit 1d0f85712085 · 2023-06-28T11:58:39.000+02:00
diff --git a/.gitignore b/.gitignore
@@ -43,3 +43,4 @@ bin/
 .idea/vcs.xml
 .idea/misc.xml
 .idea/gradle.xml
+.idea/uiDesigner.xml
diff --git a/build.gradle b/build.gradle
@@ -4,7 +4,7 @@ plugins {
 }
 
 group 'com.github.pvriel'
-version '1.2.0'
+version '1.2.1'
 
 repositories {
     mavenLocal()
diff --git a/src/main/java/com/github/pvriel/oprf4j/nroprf/semihonest/KALES19/KALES19NROPRFEvaluator.java b/src/main/java/com/github/pvriel/oprf4j/nroprf/semihonest/KALES19/KALES19NROPRFEvaluator.java
@@ -11,6 +11,10 @@
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.math.BigInteger;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.ForkJoinTask;
+import java.util.stream.IntStream;
 
 /**
  * Implementation of the {@link NROPRFEvaluator} class that uses the <a href="https://eprint.iacr.org/2019/517">KALES19 variant</a>.
@@ -40,36 +44,48 @@ public Pair<boolean[], BigInteger[]> executeOfflinePhase(BigInteger[] elements,
     }
 
     @Override
-    public BigInteger[] executeOnlinePhase(Pair<boolean[], BigInteger[]> resultOfflinePhase, BigInteger[] elements, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException {
+    public BigInteger[] executeOnlinePhase(Pair<boolean[], BigInteger[]> resultOfflinePhase, BigInteger[] elements, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException, ExecutionException, InterruptedException {
         boolean[] choices = resultOfflinePhase.getLeft();
         boolean[] b = new boolean[elements.length * bitLength];
-        for (int i = 0; i < elements.length; i ++) {
+        IntStream.range(0, elements.length).parallel().forEach(i -> {
             BigInteger element = elements[i];
             for (int j = 0; j < bitLength; j ++) b[i * bitLength + j] = (choices[i * bitLength + j] != element.testBit(j));
-        }
+        });
         BigInteger bAsBigInteger = ArrayUtils.convertToBigInteger(b);
         StreamUtils.writeBigIntegerToOutputStream(bAsBigInteger, outputStream);
         outputStream.flush();
 
         BigInteger[] r_i_j_c_i_j = resultOfflinePhase.getRight();
-        BigInteger[] R = new BigInteger[elements.length * bitLength];
-        for (int i = 0; i < elements.length; i ++) {
+        BigInteger[] C_i = new BigInteger[elements.length];
+        BigInteger[] xor_product = new BigInteger[elements.length * bitLength];
+        for (int i = 0; i < xor_product.length; i ++) xor_product[i] = StreamUtils.readBigIntegerFromInputStream(inputStream);
+        ForkJoinTask<BigInteger[]> g_modded_task = ForkJoinPool.commonPool().submit(() -> {
+            BigInteger[] g_modded = new BigInteger[elements.length];
+            for (int i = 0; i < g_modded.length; i ++) {
+                try {
+                    g_modded[i] = StreamUtils.readBigIntegerFromInputStream(inputStream);
+                } catch (IOException e) {
+                    throw new RuntimeException(e);
+                }
+            }
+            return g_modded;
+        });
+        IntStream.range(0, elements.length).parallel().forEach(i -> {
             BigInteger element = elements[i];
-            for (int j = 0; j < bitLength; j ++) R[i * bitLength + j] = r_i_j_c_i_j[i * bitLength + j].xor((element.testBit(j) ? BigInteger.ONE : BigInteger.ZERO).multiply(StreamUtils.readBigIntegerFromInputStream(inputStream)));
-        }
 
-        BigInteger[] C_i = new BigInteger[elements.length];
-        for (int i = 0; i < elements.length; i ++) {
+            BigInteger[] R = new BigInteger[bitLength];
+            for (int j = 0; j < bitLength; j ++) R[j] = r_i_j_c_i_j[i * bitLength + j].xor((element.testBit(j) ? BigInteger.ONE : BigInteger.ZERO).multiply(xor_product[i * bitLength + j]));
+
             BigInteger exponent = BigInteger.ONE;
-            for (int j = 0; j < bitLength; j ++) exponent = exponent.multiply(R[i * bitLength + j]);
+            for (int j = 0; j < bitLength; j ++) exponent = exponent.multiply(R[j]);
             C_i[i] = exponent.mod(getQ());
-        }
+        });
 
         BigInteger[] returnValue = new BigInteger[elements.length];
-        for (int i = 0; i < returnValue.length; i ++) {
-            BigInteger g_modded = StreamUtils.readBigIntegerFromInputStream(inputStream);
-            returnValue[i] = g_modded.modPow(C_i[i], getP());
-        }
+        BigInteger[] g_modded = g_modded_task.get();
+        IntStream.range(0, returnValue.length).parallel().forEach(i -> {
+            returnValue[i] = g_modded[i].modPow(C_i[i], getP());
+        });
         return returnValue;
     }
 }
diff --git a/src/main/java/com/github/pvriel/oprf4j/nroprf/semihonest/KALES19/KALES19NROPRFProvider.java b/src/main/java/com/github/pvriel/oprf4j/nroprf/semihonest/KALES19/KALES19NROPRFProvider.java
@@ -64,14 +64,16 @@ public void executeOnlinePhase(BigInteger[][] resultOfflinePhase, int amountOfVa
         for (int i = 0; i < xor_product.length; i ++) StreamUtils.writeBigIntegerToOutputStream(xor_product[i], outputStream);
         outputStream.flush();
 
-        // TODO: performance optimization.
-        for (int i = 0; i < amountOfValues; i++) {
+        BigInteger[] g_i = new BigInteger[amountOfValues];
+        IntStream.range(0, amountOfValues).parallel().forEach(i -> {
             BigInteger r_inv = BigInteger.ONE;
             for (int j = 0; j < bitLength; j++) r_inv = r_inv.multiply(r_i_j[i * bitLength + j]);
             r_inv = r_inv.modInverse(getQ());
 
-            BigInteger g_i = getG().modPow(getInitialKey().multiply(r_inv), getP());
-            StreamUtils.writeBigIntegerToOutputStream(g_i, outputStream);
+            g_i[i] = getG().modPow(getInitialKey().multiply(r_inv), getP());
+        });
+        for (int i = 0; i < amountOfValues; i++) {
+            StreamUtils.writeBigIntegerToOutputStream(g_i[i], outputStream);
         }
         outputStream.flush();
     }
diff --git a/src/main/java/com/github/pvriel/oprf4j/nroprf/semihonest/KISS17/KISS17NROPRFEvaluator.java b/src/main/java/com/github/pvriel/oprf4j/nroprf/semihonest/KISS17/KISS17NROPRFEvaluator.java
@@ -46,7 +46,9 @@ public <T> KISS17NROPRFEvaluator(int bitLengthRandomValues, PrecomputedOblivious
     @Override
     public Triple<boolean[], BigInteger[], Object> executeOfflinePhase(BigInteger[] elements, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException {
         boolean[] choices = new boolean[elements.length * bitLength];
-        for (int i = 0; i < elements.length; i ++) for (int j = 0; j < bitLength; j ++) choices[i * bitLength + j] = elements[i].testBit(j);
+        IntStream.range(0, elements.length).parallel().forEach(i -> {
+            for (int j = 0; j < bitLength; j ++) choices[i * bitLength + j] = elements[i].testBit(j);
+        });
 
         BigInteger[] g_modded = new BigInteger[elements.length];
         for (int i = 0; i < g_modded.length; i ++) g_modded[i] = StreamUtils.readBigIntegerFromInputStream(inputStream);
diff --git a/src/main/java/com/github/pvriel/oprf4j/oprf/OPRFEvaluator.java b/src/main/java/com/github/pvriel/oprf4j/oprf/OPRFEvaluator.java
@@ -25,9 +25,9 @@ public interface OPRFEvaluator {
      *          <br>This stream will not be closed after this process.
      * @return  The (not-null) OPRF (element) results.
      * @throws  IOException
-     *          If an IO-related problem occurred during the execution of this process.
+     *          If a problem occurred during the execution of this process.
      */
-    BigInteger[] evaluate(BigInteger[] elements, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException;
+    BigInteger[] evaluate(BigInteger[] elements, int bitLength, InputStream inputStream, OutputStream outputStream) throws Exception;
 
     /**
      * Method to execute the OPRF functionality.
@@ -43,9 +43,9 @@ public interface OPRFEvaluator {
      *          <br>This stream will not be closed after this process.
      * @return  The (not-null) OPRF (element) result.
      * @throws  IOException
-     *          If an IO-related problem occurred during the execution of this process.
+     *          If a problem occurred during the execution of this process.
      */
-    default BigInteger evaluate(BigInteger element, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException {
+    default BigInteger evaluate(BigInteger element, int bitLength, InputStream inputStream, OutputStream outputStream) throws Exception {
         return evaluate(new BigInteger[] {element}, bitLength, inputStream, outputStream)[0];
     }
 }
diff --git a/src/main/java/com/github/pvriel/oprf4j/oprf/OPRFProvider.java b/src/main/java/com/github/pvriel/oprf4j/oprf/OPRFProvider.java
@@ -23,10 +23,10 @@ public interface OPRFProvider {
      * @param   outputStream
      *          The (not-null) output stream to send data to the {@link OPRFEvaluator} node.
      *          <br>The stream will not be closed after this process.
-     * @throws  IOException
-     *          If an IO-related problem occurred during the execution of this process.
+     * @throws  Exception
+     *          If a problem occurred during the execution of this process.
      */
-    void execute(int amountOfValues, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException;
+    void execute(int amountOfValues, int bitLength, InputStream inputStream, OutputStream outputStream) throws Exception;
 
     /**
      * Method to provide the OPRF functionality.
@@ -38,10 +38,10 @@ public interface OPRFProvider {
      * @param   outputStream
      *          The (not-null) output stream to send data to the {@link OPRFEvaluator} node.
      *          <br>The stream will not be closed after this process.
-     * @throws  IOException
-     *          If an IO-related problem occurred during the execution of this process.
+     * @throws  Exception
+     *          If a problem occurred during the execution of this process.
      */
-    default void execute(int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException {
+    default void execute(int bitLength, InputStream inputStream, OutputStream outputStream) throws Exception {
         execute(1, bitLength, inputStream, outputStream);
     }
 }
diff --git a/src/main/java/com/github/pvriel/oprf4j/precomputed/PrecomputedOPRFEvaluator.java b/src/main/java/com/github/pvriel/oprf4j/precomputed/PrecomputedOPRFEvaluator.java
@@ -15,7 +15,7 @@
 public interface PrecomputedOPRFEvaluator<ReturnTypeOfflinePhase> extends OPRFEvaluator {
 
     @Override
-    default BigInteger[] evaluate(BigInteger[] elements, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException {
+    default BigInteger[] evaluate(BigInteger[] elements, int bitLength, InputStream inputStream, OutputStream outputStream) throws Exception {
         var resultOfflinePhase = executeOfflinePhase(elements, bitLength, inputStream, outputStream);
         return executeOnlinePhase(resultOfflinePhase, elements, bitLength, inputStream, outputStream);
     }
@@ -33,10 +33,10 @@ default BigInteger[] evaluate(BigInteger[] elements, int bitLength, InputStream
      *          The (not-null) output stream to send data to the {@link PrecomputedOPRFProvider} node.
      *          <br>This stream will not be closed after executing the protocol.
      * @return  An intermediate result, that can be used to execute the online phase of this protocol with.
-     * @throws  IOException
-     *          If an IO-related problem occurred while executing the protocol.
+     * @throws  Exception
+     *          If a problem occurred while executing the protocol.
      */
-    ReturnTypeOfflinePhase executeOfflinePhase(BigInteger[] elements, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException;
+    ReturnTypeOfflinePhase executeOfflinePhase(BigInteger[] elements, int bitLength, InputStream inputStream, OutputStream outputStream) throws Exception;
 
     /**
      * Method to execute the online phase of the OPRF protocol.
@@ -54,7 +54,7 @@ default BigInteger[] evaluate(BigInteger[] elements, int bitLength, InputStream
      *          <br>This stream will not be closed after executing the protocol.
      * @return  The not-null OPRF(element) results.
      * @throws  IOException
-     *          If an IO-related problem occurred while executing the protocol.
+     *          If a problem occurred while executing the protocol.
      */
-    BigInteger[] executeOnlinePhase(ReturnTypeOfflinePhase resultOfflinePhase, BigInteger[] elements, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException;
+    BigInteger[] executeOnlinePhase(ReturnTypeOfflinePhase resultOfflinePhase, BigInteger[] elements, int bitLength, InputStream inputStream, OutputStream outputStream) throws Exception;
 }
diff --git a/src/main/java/com/github/pvriel/oprf4j/precomputed/PrecomputedOPRFProvider.java b/src/main/java/com/github/pvriel/oprf4j/precomputed/PrecomputedOPRFProvider.java
@@ -14,7 +14,7 @@
 public interface PrecomputedOPRFProvider<ReturnTypeOfflinePhase> extends OPRFProvider  {
 
     @Override
-    default void execute(int amountOfValues, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException {
+    default void execute(int amountOfValues, int bitLength, InputStream inputStream, OutputStream outputStream) throws Exception {
         var resultOfflinePhase = executeOfflinePhase(amountOfValues, bitLength, inputStream, outputStream);
         executeOnlinePhase(resultOfflinePhase, amountOfValues, bitLength, inputStream, outputStream);
     }
@@ -34,9 +34,9 @@ default void execute(int amountOfValues, int bitLength, InputStream inputStream,
      *          <br>This stream will not be closed after executing the protocol.
      * @return  An intermediate result, that can be used to execute the online phase of this protocol with.
      * @throws  IOException
-     *          If an IO-related problem occurred while executing the protocol.
+     *          If a problem occurred while executing the protocol.
      */
-    ReturnTypeOfflinePhase executeOfflinePhase(int amountOfValues, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException;
+    ReturnTypeOfflinePhase executeOfflinePhase(int amountOfValues, int bitLength, InputStream inputStream, OutputStream outputStream) throws Exception;
 
     /**
      * Method to execute the online phase of the OPRF protocol.
@@ -53,8 +53,8 @@ default void execute(int amountOfValues, int bitLength, InputStream inputStream,
      * @param   outputStream
      *          The (not-null) output stream to send data to the {@link PrecomputedOPRFProvider} node.
      *          <br>This stream will not be closed after executing the protocol.
-     * @throws  IOException
-     *          If an IO-related problem occurred while executing the protocol.
+     * @throws  Exception
+     *          If a problem occurred while executing the protocol.
      */
-    void executeOnlinePhase(ReturnTypeOfflinePhase resultOfflinePhase, int amountOfValues, int bitLength, InputStream inputStream, OutputStream outputStream) throws IOException;
+    void executeOnlinePhase(ReturnTypeOfflinePhase resultOfflinePhase, int amountOfValues, int bitLength, InputStream inputStream, OutputStream outputStream) throws Exception;
 }
diff --git a/src/test/java/com/github/pvriel/oprf4j/AbstractOPRFTest.java b/src/test/java/com/github/pvriel/oprf4j/AbstractOPRFTest.java
@@ -20,7 +20,7 @@ public abstract class AbstractOPRFTest {
 
     @Test
     @DisplayName("Check if the OPRF function works as expected.")
-    public void test() throws IOException, InterruptedException {
+    public void test() throws Exception {
         Triple<Integer, Pair<BigInteger[], BigInteger[]>, Pair<OPRFProvider, OPRFEvaluator>> setup = setup();
         int bitLength = setup.getLeft();
         Pair<BigInteger[], BigInteger[]> inputsAndExpectedOutputs = setup.getMiddle();

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ plugins {`
`4`	`4`	`}`
`5`	`5`
`6`	`6`	`group 'com.github.pvriel'`
`7`		`-version '1.2.0'`
	`7`	`+version '1.2.1'`
`8`	`8`
`9`	`9`	`repositories {`
`10`	`10`	`mavenLocal()`