Clarify workspace-change-privilege Button
#881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Privileged/unprivileged button now lists debug[x] to clarify the button's purpose
Member
|
@TheodorKitzenmaier can add a screenshot (before/after) and then ping me and @zardus when you have it. |
Contributor
Author
|
The current practice/debug/privileged toggle: OFF: New toggle: OFF: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the purpose of the
workspace-change-privilegebutton by adding the textDebug[<icon>]to the button.The icon is either a check or times (X) based on if the challenge is in practice/privileged/sudo/debug/whateverwe'recallingitatthispoint mode or not. This is hopefully more clear to end users than the previous lock/unlock icons.