Skip to content

Commit 0f1a845

Browse files
authored
No WASM build in CI (#952)
* no wasm * update changelog
1 parent 12850e1 commit 0f1a845

File tree

2 files changed

+3
-44
lines changed

2 files changed

+3
-44
lines changed

.github/workflows/build-and-relase.yaml

Lines changed: 2 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -136,43 +136,6 @@ jobs:
136136
name: wheels-macos-${{ matrix.platform.target }}
137137
path: dist
138138

139-
emscripten:
140-
runs-on: ${{ matrix.platform.runner }}
141-
strategy:
142-
matrix:
143-
platform:
144-
- runner: ubuntu-22.04
145-
target: wasm32-unknown-emscripten
146-
steps:
147-
- uses: actions/checkout@v4
148-
- run: pip install pyodide-build
149-
- name: Get Emscripten and Python version info
150-
shell: bash
151-
run: |
152-
echo EMSCRIPTEN_VERSION=$(pyodide config get emscripten_version) >> $GITHUB_ENV
153-
echo PYTHON_VERSION=$(pyodide config get python_version | cut -d '.' -f 1-2) >> $GITHUB_ENV
154-
pip uninstall -y pyodide-build
155-
- uses: mymindstorm/setup-emsdk@v12
156-
with:
157-
version: ${{ env.EMSCRIPTEN_VERSION }}
158-
actions-cache-folder: emsdk-cache
159-
- uses: actions/setup-python@v5
160-
with:
161-
python-version: ${{ env.PYTHON_VERSION }}
162-
- run: pip install pyodide-build
163-
- name: Build wheels
164-
uses: PyO3/maturin-action@v1
165-
with:
166-
target: ${{ matrix.platform.target }}
167-
args: --release --out dist -i ${{ env.PYTHON_VERSION }}
168-
sccache: ${{ !startsWith(github.ref, 'refs/tags/') }}
169-
rust-toolchain: nightly
170-
- name: Upload wheels
171-
uses: actions/upload-artifact@v4
172-
with:
173-
name: wasm-wheels
174-
path: dist
175-
176139
sdist:
177140
runs-on: ubuntu-latest
178141
steps:
@@ -192,7 +155,7 @@ jobs:
192155
name: Release
193156
runs-on: ubuntu-latest
194157
if: ${{ startsWith(github.ref, 'refs/tags/') || github.event_name == 'workflow_dispatch' }}
195-
needs: [linux, musllinux, windows, macos, emscripten, sdist]
158+
needs: [linux, musllinux, windows, macos, sdist]
196159
permissions:
197160
# Use to sign the release artifacts
198161
id-token: write
@@ -217,6 +180,5 @@ jobs:
217180
- name: Upload to GitHub Release
218181
uses: softprops/action-gh-release@v1
219182
with:
220-
files: |
221-
wasm-wheels/*.whl
183+
files: ""
222184
prerelease: ${{ contains(github.ref, 'alpha') || contains(github.ref, 'beta') }}

docs/changelog.qmd

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ pf.etable([fit_nb, fit_rust], digits = 8)
7373
learn more about all features and take a look at more systematic benchmarks in the [quantreg vignette](https://py-econometrics.github.io/pyfixest/quantile-regression.html).
7474

7575
```{python}
76-
N_qr = 100_000
76+
N_qr = 10_000
7777
rng = np.random.default_rng(929)
7878
7979
df_qr = pd.DataFrame({
@@ -82,16 +82,13 @@ df_qr = pd.DataFrame({
8282
})
8383
df_qr["Y"] = -0.5 + -2 * df_qr["X1"] + 1.9 * df_qr["X1"] ** 4 + df_qr["X2"] - 0.4 * df_qr["X2"] **7 + rng.normal(0, 1, N_qr)
8484
85-
tic = time.time()
8685
fit_qr = pf.quantreg(
8786
fml = "Y ~ X1 + X2",
8887
data = df_qr,
8988
quantile = [0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9],
9089
method = "pfn",
9190
multi_method = "cfm2"
9291
)
93-
toc = time.time()
94-
print(f"Fit the entire quantile regression process with {N_qr} obs and k = 3 in {np.round(toc-tic)} seconds.")
9592
9693
pf.qplot(fit_qr, figsize = [7,3])
9794
```

0 commit comments

Comments
 (0)