Fix issue #1254: pass the variable 'categorical' instead of the method 'is_categorical'

Yangliu-SY · web-flow · commit a8c0ffa87d18 · 2024-10-01T17:46:12.000+02:00
Based on the context of the codes, the variable 'categorical' should be passed in the function call of '_estimate_conditional_expectations' instead of the method 'is_categorical'

Signed-off-by: Yangliu-SY &lt;144334404+Yangliu-SY@users.noreply.github.com&gt;
diff --git a/dowhy/gcm/model_evaluation.py b/dowhy/gcm/model_evaluation.py
@@ -454,7 +454,7 @@ def evaluate_node(node_name, random_seed):
                 )
 
                 conditional_expectations = _estimate_conditional_expectations(
-                    tmp_causal_mechanism, parent_data[test_indices], is_categorical, 50
+                    tmp_causal_mechanism, parent_data[test_indices], categorical, 50
                 )
                 if categorical:
                     metric_evaluations["F1"].append(

Original file line number	Diff line number	Diff line change
`@@ -454,7 +454,7 @@ def evaluate_node(node_name, random_seed):`
`454`	`454`	`)`
`455`	`455`
`456`	`456`	`conditional_expectations = _estimate_conditional_expectations(`
`457`		`- tmp_causal_mechanism, parent_data[test_indices], is_categorical, 50`
	`457`	`+ tmp_causal_mechanism, parent_data[test_indices], categorical, 50`
`458`	`458`	`)`
`459`	`459`	`if categorical:`
`460`	`460`	`metric_evaluations["F1"].append(`