Update the causal discovery notebook with examples using causal-learn #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emrekiciman
reviewed
Aug 31, 2023
docs/source/example_notebooks/dowhy_causal_discovery_example.ipynb
Outdated
Show resolved
Hide resolved
docs/source/example_notebooks/dowhy_causal_discovery_example.ipynb
Outdated
Show resolved
Hide resolved
|
This looks great @kunwuz thank you for updating this notebook! |
emrekiciman
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Actually, sorry, I saw that the references to CDT in the text, and using CDT to load the sachs dataset are still in the PR. I think that's the only blocker to integration. Or, @kunwuz , do you want to merge this PR now and then fix those issues with a separate PR?
|
Thanks for the reminder. I've added a new load_dataset function in causal-learn recently, so now we can just use causal-learn to load real-world datasets (e.g., Sachs). I will modify the notebook in this PR soon. |
Signed-off-by: kunwuz <514397511@qq.com>
Signed-off-by: kunwuz <514397511@qq.com>
Signed-off-by: kunwuz <514397511@qq.com>
Signed-off-by: kunwuz <514397511@qq.com>
Signed-off-by: kunwuz <514397511@qq.com>
emrekiciman
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the old notebook as mentioned in #1021.