Fix pandas FutureWarnings in calls to .groupby() #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrent behavior and silence the pandas FutureWarning Signed-off-by: Dylan W <139509928+dw-610@users.noreply.github.com>
amit-sharma
reviewed
Apr 22, 2024
| @@ -256,7 +256,7 @@ | |||
| }, | |||
| { | |||
| "data": { | |||
There was a problem hiding this comment.
can you avoid making changes to the "data" field?
you can do by checking out the remote version of this file and only changing the groupby line.
amit-sharma
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Thanks for these changes @dw-610 They look good to merge, but there's a minor comment I made inline. Can you take a look at that and avoid major changes to the notebook file?
…ta' field Signed-off-by: Dylan W <139509928+dw-610@users.noreply.github.com>
…rning Signed-off-by: Dylan W <139509928+dw-610@users.noreply.github.com>
dw-610
force-pushed
the
fix-pandas-futurewarnings
branch
from
722ca98 to
58960e0
Compare
|
Thanks for the feedback @amit-sharma The issue should be resolved now. |
|
Thanks! @all-contributors please add @dw-610 for code |
|
I've put up a pull request to add @dw-610! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, with pandas version 2.2.2, calls to .groupby() raise the warning below:
FutureWarning: The default of observed=False is deprecated and will be changed to True in a future version of pandas. Pass observed=False to retain current behavior or observed=True to adopt the future default and silence this warning.Solution
To retain current behavior and silence this warning, observed=False was added to all calls to .groupby()