KeyError: 'label' error message could be more clear

[lgmoneda]

When you miss declaring a node in your causal graph, it's going to throw a KeyError: 'label' error. It could be more explicit to make debugging easier. I think it would be nice to inform what is the node hough used in the graph.

[akelleh]

Great suggestion. We might need a broader overhaul of logging and exception handling. What do you think @amit-sharma ?

[yemaedahrav]

Is this error caused when calling the 'CausalModel()' when it internally creates the graph through the 'CausalGraph()' API or somewhere else? because I am not able to reproduce the error locally.

[amit-sharma]

I think this error is raised when you input your own graph as a string and forget to add all required nodes. So if you provide a dot graph with missing nodes, and then call CausalModel with that graph, it should throw this error.

[lgmoneda]

Hi! I'm unsure if it persists since I'm not currently using the library. But the point was that the error message didn't help as much as it could in identifying what the missing nodes were.

[rahulbshrestha]

Hey @amit-sharma! I would like to help out in fixing this bug. Can you let me know what kind of error message do you expect?

[amit-sharma]

thanks for contributing, @rahulbshrestha It will be nice to output an error message that describes the source of the bug. Something like, "Some nodes are missing in the graph: {node1name, node2name} "

[rahulbshrestha]

I can't seem to reproduce this issue, how can I provide a dot graph with missing nodes such that the KeyError appears?

Experimenting with this:

# With DOT string
model=CausalModel(
        data = df,
        treatment='X',
        outcome='Y',
        graph="digraph {Z -> X;Z -> Y;X -> Y;}"
        )
model.view_model()

where, df consists of X,Y and Z as columns.

I'm not sure if @lgmoneda meant in this case

# With GML string
model=CausalModel(
        data = df,
        treatment='X',
        outcome='Y',
        graph="""graph[directed 1 node[id "Z" label "Z"]
                    node[id "X" label "X"]
                    #node[id "Y" label "Y"]
                    edge[source "Z" target "X"]
                    edge[source "Z" target "Y"]
                    edge[source "X" target "Y"]]"""

        )
model.view_model()

where an NetworkXError: edge #1 has undefined target 'Y' error is thrown if we remove the node Y.

[amit-sharma]

Try this. Does the following code raise the error?

model=CausalModel(
data = df,
treatment='X',
outcome='Y',
graph="digraph {Z -> X;}"
)
model.view_model()

[rahulbshrestha]

Nope, it works perfectly fine

[amit-sharma]

Thanks for checking @rahulbshrestha Looks like this issue is resolved in the current version. We can close this issue.