Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential API changes in http_sfv (dependency) #6

Open
mnot opened this issue Oct 12, 2022 · 2 comments
Open

Potential API changes in http_sfv (dependency) #6

mnot opened this issue Oct 12, 2022 · 2 comments

Comments

@mnot
Copy link

mnot commented Oct 12, 2022

Hi,

I'm looking at changes to http_sfv, and noticed that this library depends upon it.

See a summary of how it would work. Basically, it's moving from an object-based approach to a set of functions that produce datastructures. This should be more performant and I think more straightforward to use.

I'm writing here to ask:

  1. If you have any thoughts / preferences about the API.
  2. If the new API is merged, how you'd like to manage the dependency. I'd probably version it as 0.10.1, FWIW.
@kislyuk
Copy link
Member

kislyuk commented Oct 14, 2022

Hi - this seems fine, I don't have any strong preferences one way or another. I have a vague idea that an object-oriented API might make it easier to type hint the interfaces appropriately, but I'm not sure if that's a good reason to stay with that approach.

To manage the dependency, I imagine I'd start by publishing a release to this package to depend on http-sfv >= 0.9.8, < 0.10. Then once you publish your update I will do a release that updates the API and depends on http-sfv >= 0.10.1. Does that sound right? If so, I can push an update in the next day or two.

@kislyuk
Copy link
Member

kislyuk commented Oct 14, 2022

Also, thanks for publishing http-sfv. It's a really useful package and important building block that has been reliable and predictable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants