Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VerificationError should indicate which cert is being checked #11160

Closed
nbastin opened this issue Jun 25, 2024 · 0 comments
Closed

VerificationError should indicate which cert is being checked #11160

nbastin opened this issue Jun 25, 2024 · 0 comments
Labels
x509

Comments

@nbastin
Copy link
Contributor

nbastin commented Jun 25, 2024

VerificationError exceptions don't report which cert causes the problem, which can make debugging fairly time consuming (or impossible, if you're not in the situation of issuing your own certs).
@alex alex added the x509 label Jun 25, 2024
alex added a commit to alex/cryptography that referenced this issue Oct 28, 2024
@alex
start refactoring ValidationError in prep for tracking which cert h…
1da0171 
…ad the error

The end goal is that `ValidationError` will include a cert field, which optionally contains a `VerificationCertificate` where relevant

refs pyca#11160
@alex alex mentioned this issue Oct 28, 2024
Merged
alex added a commit to alex/cryptography that referenced this issue Oct 28, 2024
@alex
start refactoring ValidationError in prep for tracking which cert h…
d289cd5 
…ad the error

The end goal is that `ValidationError` will include a cert field, which optionally contains a `VerificationCertificate` where relevant

refs pyca#11160
alex added a commit to alex/cryptography that referenced this issue Oct 28, 2024
@alex
start refactoring ValidationError in prep for tracking which cert h…
3d0494f 
…ad the error

The end goal is that `ValidationError` will include a cert field, which optionally contains a `VerificationCertificate` where relevant

refs pyca#11160
alex added a commit to alex/cryptography that referenced this issue Oct 28, 2024
@alex
start refactoring ValidationError in prep for tracking which cert h…
e4f53f7 
…ad the error

The end goal is that `ValidationError` will include a cert field, which optionally contains a `VerificationCertificate` where relevant

refs pyca#11160
alex added a commit to alex/cryptography that referenced this issue Oct 30, 2024
@alex
Pass VerificationCertificate slightly deeper in the callstack
685ffbb 
refs pyca#11160
@alex alex mentioned this issue Oct 30, 2024
Merged
alex added a commit to alex/cryptography that referenced this issue Oct 30, 2024
@alex
Use a type alias for ValidationResult
094f584 
refs pyca#11160
@alex alex mentioned this issue Oct 30, 2024
Merged
reaperhulk pushed a commit that referenced this issue Oct 30, 2024
@alex
Pass VerificationCertificate slightly deeper in the callstack (#11865)
73f5758 
refs #11160
reaperhulk pushed a commit that referenced this issue Oct 30, 2024
@alex
Use a type alias for ValidationResult (#11866)
e2fce25 
refs #11160
alex added a commit to alex/cryptography that referenced this issue Oct 31, 2024
@alex
start refactoring ValidationError in prep for tracking which cert h…
14208f7 
…ad the error

The end goal is that `ValidationError` will include a cert field, which optionally contains a `VerificationCertificate` where relevant

refs pyca#11160
reaperhulk pushed a commit that referenced this issue Nov 3, 2024
@alex
start refactoring ValidationError in prep for tracking which cert h…
9e46c93 
…ad the error (#11844)

The end goal is that `ValidationError` will include a cert field, which optionally contains a `VerificationCertificate` where relevant

refs #11160
alex added a commit to alex/cryptography that referenced this issue Nov 3, 2024
@alex
Added a certificate field to verification error.
45fe20e 
refs pyca#11160
@alex alex mentioned this issue Nov 3, 2024
Merged
alex added a commit to alex/cryptography that referenced this issue Nov 3, 2024
@alex
Added a certificate field to verification error.
1f58055 
refs pyca#11160
reaperhulk pushed a commit that referenced this issue Nov 5, 2024
@alex
Added a certificate field to verification error. (#11882)
26b293c 
refs #11160
alex added a commit to alex/cryptography that referenced this issue Nov 5, 2024
@alex
fixes pyca#11160 -- include the cert in the error message for verific…
21d9d97 
…ation error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
x509
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex @nbastin