Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-add an independent page for sponsors #437

Closed
wants to merge 3 commits into from
Closed

feat-add an independent page for sponsors #437

wants to merge 3 commits into from

Conversation

SivanYeh
Copy link
Collaborator

@SivanYeh SivanYeh commented Aug 6, 2023

  • New feature

Related Issue

#426

Additional context

@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for ephemeral-sable-89c7e0 ready!

Name Link
🔨 Latest commit 6c9730b
🔍 Latest deploy log https://app.netlify.com/sites/ephemeral-sable-89c7e0/deploys/64e73837bb92a600083cfe8e
😎 Deploy Preview https://deploy-preview-437--ephemeral-sable-89c7e0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SivanYeh
Copy link
Collaborator Author

SivanYeh commented Aug 6, 2023

@josix is it the right way to achieve this feature?

@baby230211 baby230211 marked this pull request as ready for review August 21, 2023 13:14
Comment on lines 54 to 57
if (ccip) {
return 'ccip'
}
return 'default'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前一個 ccip layout switch PR 的同個地方是否改了什麼XD

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for notice lol

@josix
Copy link
Collaborator

josix commented Aug 26, 2023

@SivanYeh I've created another PR #452 to fix the issues that couldn't display the sponsors' logos. PTAL thanks!

@josix josix closed this Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants