Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle breaking change with pydicom 3 #266

Open
sammaxwellxyz opened this issue Oct 1, 2024 · 2 comments
Open

Handle breaking change with pydicom 3 #266

sammaxwellxyz opened this issue Oct 1, 2024 · 2 comments

Comments

@sammaxwellxyz
Copy link
Contributor

recent pydicom release includes breaking change

https://github.com/pydicom/pydicom/releases/tag/v3.0.0

the install requires needs an upper bound or the code updated, a particular breaking change is the attempted use of read_file from dicom/header.py

@vsoch
Copy link
Member

vsoch commented Oct 1, 2024

The change / fix seems pretty small - change read_file to dcmread. Would you care to PR to update the library here? We will need to do another more major bump in terms of version as well to indicate it is a breaking change.

@sammaxwellxyz
Copy link
Contributor Author

Nice, will put that together, in the meantime I created a PR for capping the version if your prefer #267, by all means dismiss :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants