Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No python 2.6 subprocess.check_output #9

Open
frimik opened this issue Jun 25, 2017 · 0 comments
Open

No python 2.6 subprocess.check_output #9

frimik opened this issue Jun 25, 2017 · 0 comments

Comments

@frimik
Copy link

frimik commented Jun 25, 2017

setuptools-git-version fails on python 2.6... I pulled in the 2.7 version of check_output into my setup.py like this:

from setuptools import setup, find_packages
import subprocess

if "check_output" not in dir(subprocess):  # duck punch check_output
    from subprocess import Popen, PIPE, CalledProcessError
    STDOUT = subprocess.STDOUT

    def check_output(*popenargs, **kwargs):
        r"""Run command with arguments and return its output as a byte string.

        If the exit code was non-zero it raises a CalledProcessError.  The
        CalledProcessError object will have the return code in the returncode
        attribute and output in the output attribute.

        The arguments are the same as for the Popen constructor.  Example:

        >>> check_output(["ls", "-l", "/dev/null"])
        'crw-rw-rw- 1 root root 1, 3 Oct 18  2007 /dev/null\n'

        The stdout argument is not allowed as it is used internally.
        To capture standard error in the result, use stderr=STDOUT.

        >>> check_output(["/bin/sh", "-c",
        ...               "ls -l non_existent_file ; exit 0"],
        ...              stderr=STDOUT)
        'ls: non_existent_file: No such file or directory\n'
        """
        if 'stdout' in kwargs:
            raise ValueError(
                'stdout argument not allowed, it will be overridden.')
        process = Popen(stdout=PIPE, *popenargs, **kwargs)
        output, unused_err = process.communicate()
        retcode = process.poll()
        if retcode:
            cmd = kwargs.get("args")
            if cmd is None:
                cmd = popenargs[0]

            raise CalledProcessError(retcode, cmd, output=output)
        return output

    subprocess.check_output = check_output

Now my builds are happy:

  py26: commands succeeded
  py27: commands succeeded
  py36: commands succeeded
  congratulations :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant