update

Author: rusty1s

.github/workflows/testing.yml

@@ -64,7 +64,7 @@ jobs:
         if: steps.changed-files-specific.outputs.only_changed != 'true'
         timeout-minutes: 10
         run: |
-          pytest --cov --cov-report=xml --durations 10
+          FULL_TEST=1 pytest --cov --cov-report=xml --durations 10
 
       - name: Upload coverage
         if: ${{ steps.changed-files-specific.outputs.only_changed != 'true' && runner.os == 'Linux' }}

test/nn/conv/test_message_passing.py

@@ -740,3 +740,24 @@ def test_pickle(tmp_path):
 
     model = torch.load(path)
     torch.jit.script(model)
+
+
+class MyOptionalEdgeAttrConv(MessagePassing):
+    def __init__(self):
+        super().__init__()
+
+    def forward(self, x, edge_index, edge_attr=None):
+        return self.propagate(edge_index, x=x, edge_attr=edge_attr)
+
+    def message(self, x_j, edge_attr=None):
+        return x_j if edge_attr is None else x_j * edge_attr.view(-1, 1)
+
+
+def test_my_optional_edge_attr_conv():
+    conv = MyOptionalEdgeAttrConv()
+
+    x = torch.randn(4, 8)
+    edge_index = torch.tensor([[0, 1, 2, 3], [0, 0, 1, 1]])
+
+    out = conv(x, edge_index)
+    assert out.size() == (4, 8)

torch_geometric/nn/conv/collect.jinja

@@ -96,17 +96,6 @@ def {{collect_name}}(
     else:
         raise NotImplementedError
 
-{%- if 'edge_weight' in collect_param_dict and
-    collect_param_dict['edge_weight'].type_repr.endswith('Tensor') %}
-    assert edge_weight is not None
-{%- elif 'edge_attr' in collect_param_dict and
-    collect_param_dict['edge_attr'].type_repr.endswith('Tensor') %}
-    assert edge_attr is not None
-{%- elif 'edge_type' in collect_param_dict and
-    collect_param_dict['edge_type'].type_repr.endswith('Tensor') %}
-    assert edge_type is not None
-{%- endif %}
-
     # Collect user-defined arguments:
 {%- for name in collect_param_dict %}
 {%- if (name.endswith('_i') or name.endswith('_j')) and