Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements (I hope) to the mv.py and lt.py modules #478

Closed
Greg1950 opened this issue Nov 5, 2021 · 2 comments
Closed

Improvements (I hope) to the mv.py and lt.py modules #478

Greg1950 opened this issue Nov 5, 2021 · 2 comments
Milestone

Comments

@Greg1950
Copy link
Contributor

Greg1950 commented Nov 5, 2021

I have made a number of changes to the mv.py and lt.py modules, changes which I believe address the issues about which I've previously posted. I've improved the treatment of spinor-based orthogonal transformations so that now one can instantiate an orthogonal transformation using versors, a broader set of multivectors than are spinors. And I've added to the multivector methods in mv.py several new methods, most of them inspired by Dorst, Fontijne, & Mann's Geometric Algebra for Computer Science.

The changed modules have met every test I've made of them. They are placed in the galgebra folder of the attached zip file. Another folder, notebooks, contains four Jupyter notebooks. Two of them describe precisely the changes I've made to the modules' code. The other two are oriented towards GAlgebra users (as opposed to programmers). A Read Me First file has been placed at the top level within the archive.

I'm much better at mathematics than programming. My level of skill at the latter goes no further than a couple of introductory CS courses from M.I.T.'s edX division. So I would appreciate it if readers of this GitHub issues forum, who are almost certainly better programmers than me, would look over the modified modules and test their functioning.

(Changes in the indicated modules are delimited by comment lines ### GSG code starts ### and ### GSG code ends ###. Those comment lines are there to aid real programmers in locating the modifications I've made. They should be stripped out if it's decided by the PyGAE GAlgebra group that the modification should be kept.)

I can be contacted at g.s.grunberg@gmail.com.

Greg Grunberg

GSG_2021-11-05_GAlgebra_fixes.zip

@utensil utensil added this to the 0.6.0 milestone Mar 30, 2024
@utensil
Copy link
Member

utensil commented Mar 30, 2024

x-ref: #475

@utensil utensil mentioned this issue Apr 6, 2024
11 tasks
utensil added a commit that referenced this issue Apr 7, 2024
…minor fixes

Co-authored-by: Greg Grunberg <g.s.grunberg@gmail.com>
@utensil
Copy link
Member

utensil commented May 15, 2024

Thank you, @Greg1950 , I believe this is covered by your improvements merged by #510 . Feel free to reopen if there are remaining issues.

@utensil utensil closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants