-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge features from abrombo's branch #88
Comments
➡️ Let's track this in #39 .
➡️ Let's track this in #19
❓ Not sure what action needs taking here.
✔️ Partially addressed in #342, but we should use them throughout the printer. Let's track this in #399.
➡️ Let's track this in #400
✔️ Flake8 CI will ensure that none of this actually makes it in
✔️ Handled by #375
❓ This example seems to depend on a lot of code that was never committed, such as an implementation of
✔️ Solved already, I forget where.
✔️ For ❓ What to do about extra preamble? |
@utensil, updated my comment above with a summary of every bullet point |
We could clean up the API of xpdf and introduce xtex as in this branch . |
What extra preamble? |
I don't feel any strong urge to do that before 0.5.0. Fine to bump to 0.6.0?
abrombo's branch contains a bunch of extra latex preamble which is printed at the start of a jupyter notebook by |
OK. |
Oh, I see. I didn't like the approach very much since it introduced a dependency on the preamble and makes the printed MathJax no longer free-standing. On the other hand, I do appreciate the fact that it makes the printer LaTeX more succinct and thus I'm not against this change but wishes to be able to opt-out but that's only a nice-to-have enhancement. |
This is currently tracked by #62 and #39 .
Mirroring a slack discussion:
@abrombo replied:
The text was updated successfully, but these errors were encountered: