From 6e9df8bb2e9558ff2846b0b875bf1896a7d125df Mon Sep 17 00:00:00 2001 From: Eric Wieser Date: Wed, 13 Nov 2019 16:07:48 +0000 Subject: [PATCH] Don't pull ganja.js when this module is installed As previously written, it makes it very difficult to roll back ganja.js. After this change, the user will get the version of ganja.js that pyganja was tested with, not just blindly the latest version. This is consistent with what they will get with PyPI There's nothing to stop a user pulling a newer version locally after this change, if they still want the latest. --- setup.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/setup.py b/setup.py index 88f6dd9..2ead7eb 100644 --- a/setup.py +++ b/setup.py @@ -9,7 +9,6 @@ def run(self): if path.exists('.git'): subprocess.check_call(['git', 'submodule', 'init']) subprocess.check_call(['git', 'submodule', 'update']) - subprocess.check_call(['git', 'submodule', 'foreach', 'git', 'pull', 'origin', 'master']) build.run(self) class install_with_submodules(install): @@ -17,7 +16,6 @@ def run(self): if path.exists('.git'): subprocess.check_call(['git', 'submodule', 'init']) subprocess.check_call(['git', 'submodule', 'update']) - subprocess.check_call(['git', 'submodule', 'foreach', 'git', 'pull', 'origin', 'master']) install.run(self) setup(