Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampler-wise tune stats are not recognized & InferenceData left with 0 draws #102

Closed
michaelosthege opened this issue Jan 17, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@michaelosthege
Copy link
Member

In pymc-devs/pymc#6835 (released in PyMC v5.7.0) the emission of the "tune" stat was changed to be a sampler-wise thing, which is why McBackend can no longer find it in the stored sample stats.

This triggered a second bug in .to_inferencedata(), where a np.repeat was used instead of a np.fill, leading to an empty array, that masked away all draws & stats.

Credits for the discovery go to @mamacneil via https://discourse.pymc.io/t/using-mcbackend-to-store-samples/13529.

@michaelosthege michaelosthege added the bug Something isn't working label Jan 17, 2024
@michaelosthege michaelosthege self-assigned this Jan 17, 2024
michaelosthege added a commit that referenced this issue Jan 17, 2024
michaelosthege added a commit that referenced this issue Jan 17, 2024
This restores compatibility with MCMC runs from PyMC >= 5.7.0.

Closes #102
michaelosthege added a commit that referenced this issue Jan 17, 2024
This restores compatibility with MCMC runs from PyMC >= 5.7.0.

Closes #102
michaelosthege added a commit that referenced this issue Jan 17, 2024
This restores compatibility with MCMC runs from PyMC >= 5.7.0.

Closes #102
michaelosthege added a commit that referenced this issue Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant