From 2af4afb54aaf2b0d9141499598d2f456c68e0d7c Mon Sep 17 00:00:00 2001 From: amyoshino Date: Sun, 2 Jul 2023 17:59:35 -0400 Subject: [PATCH 1/4] adding description to Gumbel Distribution" --- pymc/distributions/continuous.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pymc/distributions/continuous.py b/pymc/distributions/continuous.py index cffea7f94e..638dc2573c 100644 --- a/pymc/distributions/continuous.py +++ b/pymc/distributions/continuous.py @@ -3121,7 +3121,11 @@ def triangular_default_transform(op, rv): class Gumbel(Continuous): r""" - Univariate Gumbel log-likelihood. + Univariate Gumbel right Skew log-likelihood. + + This parameterization will provide the extreme maximum value. + Those looking to find the extreme minimum provided by the left skewed Gumbel should + invert the sign to all X and Y values (positive to negative and negative to positive). The pdf of this distribution is From 0b11e5c8490cd6a92556ee51893f03c7d421b832 Mon Sep 17 00:00:00 2001 From: "Adriano M. Yoshino" Date: Thu, 13 Jul 2023 09:01:16 -0400 Subject: [PATCH 2/4] Apply suggestions from code review Co-authored-by: larryshamalama --- pymc/distributions/continuous.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pymc/distributions/continuous.py b/pymc/distributions/continuous.py index 638dc2573c..40050d3751 100644 --- a/pymc/distributions/continuous.py +++ b/pymc/distributions/continuous.py @@ -3121,11 +3121,11 @@ def triangular_default_transform(op, rv): class Gumbel(Continuous): r""" - Univariate Gumbel right Skew log-likelihood. + Univariate right skewed Gumbel log-likelihood. This parameterization will provide the extreme maximum value. Those looking to find the extreme minimum provided by the left skewed Gumbel should - invert the sign to all X and Y values (positive to negative and negative to positive). + invert the sign to all X and Y values. The pdf of this distribution is From 37d1495cbbbc9668af22fad5965af061d0f67347 Mon Sep 17 00:00:00 2001 From: amyoshino Date: Thu, 13 Jul 2023 10:41:25 -0400 Subject: [PATCH 3/4] Adding fix for the suggestions --- pymc/distributions/continuous.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pymc/distributions/continuous.py b/pymc/distributions/continuous.py index 40050d3751..5fd9284989 100644 --- a/pymc/distributions/continuous.py +++ b/pymc/distributions/continuous.py @@ -3121,11 +3121,11 @@ def triangular_default_transform(op, rv): class Gumbel(Continuous): r""" - Univariate right skewed Gumbel log-likelihood. + Univariate right-skewed Gumbel log-likelihood. - This parameterization will provide the extreme maximum value. - Those looking to find the extreme minimum provided by the left skewed Gumbel should - invert the sign to all X and Y values. + This distribution is typically used for modeling maximum (or extreme) values. + Those looking to find the extreme minimum provided by the left-skewed Gumbel should + invert the sign to all x and mu values. The pdf of this distribution is From 12d2d7aee83e6f8c6889ac8cb4efa5099e09b690 Mon Sep 17 00:00:00 2001 From: larryshamalama Date: Sun, 13 Aug 2023 10:53:28 -0400 Subject: [PATCH 4/4] "to" -> "of" --- pymc/distributions/continuous.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pymc/distributions/continuous.py b/pymc/distributions/continuous.py index 5fd9284989..1df2bd6efe 100644 --- a/pymc/distributions/continuous.py +++ b/pymc/distributions/continuous.py @@ -3125,7 +3125,7 @@ class Gumbel(Continuous): This distribution is typically used for modeling maximum (or extreme) values. Those looking to find the extreme minimum provided by the left-skewed Gumbel should - invert the sign to all x and mu values. + invert the sign of all x and mu values. The pdf of this distribution is