Updates workflow .yaml to try to ignore draft PRs. #4812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorjMcKie
approved these changes
Nov 27, 2025
Collaborator
julian-smith-artifex-com
left a comment
julian-smith-artifex-com
left a comment
There was a problem hiding this comment.
I'd prefer to leave this file unchanged.
A simpler solution would be to make a PR target a dummy thread, not main. In this case test_quick will not be run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
Added
if: github.event.pull_request.draft == false || github.event_name == 'workflow_dispatch'to both jobs. This condition:The condition is necessary for both triggers because workflow_dispatch doesn't have a pull_request object, so we need the
|| github.event_name == 'workflow_dispatch'part to avoid errors if manually running the workflow.