Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acorn-import-assertions is no longer available if using newer webpack #29

Closed
yuttie opened this issue Oct 18, 2024 · 1 comment
Closed

Comments

@yuttie
Copy link

yuttie commented Oct 18, 2024

The acorn-import-assertions package is used here, but it is missing from package.json as a direct dependency.

With older versions of webpack (e.g. v5.88.2 as indicated in the package-lock.json), acorn-import-assertions is installed indirectly as a dependency of webpack, so the issue does not surface.

However, with recent versions of webpack, acorn-import-assertions is no longer the dependency of webpack, which leads to a build error:

ERROR in ./node_modules/pyodide/pyodide.mjs
Module build failed (from ./node_modules/@pyodide/webpack-plugin/loader.cjs):
Error: Cannot find module 'acorn-import-assertions'
@mneil mneil closed this as completed in 874000c Oct 21, 2024
@mneil
Copy link
Collaborator

mneil commented Oct 21, 2024

Fixed in #30 . @pyodide/webpack-plugin version 1.3.3 should resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants