You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TopoModelX contains some scatter functions in utils.scatter, that -- according to the module docstring -- are adapted from torch_scatter. Is there a specific reason why we ship our own implementation? torch_scatter is a dependency already.
If yes, we should document that reason and how the build-in implementation differs from torch_scatter (which, for me, is not at all obvious from looking at the code). Otherwise remove it and use the existing implementation in torch_scatter everywhere.
The text was updated successfully, but these errors were encountered:
TopoModelX contains some scatter functions in
utils.scatter
, that -- according to the module docstring -- are adapted fromtorch_scatter
. Is there a specific reason why we ship our own implementation?torch_scatter
is a dependency already.If yes, we should document that reason and how the build-in implementation differs from
torch_scatter
(which, for me, is not at all obvious from looking at the code). Otherwise remove it and use the existing implementation intorch_scatter
everywhere.The text was updated successfully, but these errors were encountered: