Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and rewrite models that are not using topomodelx.base.conv primitives #247

Open
6 tasks
levtelyatnikov opened this issue Nov 1, 2023 · 0 comments
Open
6 tasks
Assignees

Comments

@levtelyatnikov
Copy link
Collaborator

levtelyatnikov commented Nov 1, 2023

Examine the models to determine whether it was necessary to avoid using primitives from topomodelx.base.conv. If it turns out that avoiding them was not justified, update the models by incorporating these topomodelx.base.conv primitives.

  • UniGCNIILayer
  • UniGINLayer
  • UniSAGELayer
  • HyperGAT (Note: HyperGat precomputes normalization during model initialization. Hence, it is impossible to use for graph-level tasks when the incidence matrices are different.)
  • HNHN (Note: HNHN takes as input incidence matrix to employ normalization possibly, it can be moved into forward pass to allow different incidence matrices)
  • HyperSAGE (Note: 1) not train/validation modes as well as node sampling, 2) slow due to loops and .to(device) to allow gpu )
@Coerulatus Coerulatus self-assigned this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants