You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two important concerns about SCConv simplicial model:
Implementation of normalization: The original paper consider normalized incidence and adjacency matrices, but the proposed normalization procedure in the tutorial does not work. Currently, the model runs without any normalization.
Improving readability: The notation of incidence and adjacency matrices is difficult to follow; this needs to be carefully revised for the model to be further used.
The text was updated successfully, but these errors were encountered:
please take a look at that PR, and let me know if other normalization are needed. I am going to work on the suggestions in that PR in there today and if you have more suggestions let me know.
Really nice and practical addition to TopoNetX! For sure point 1 can be easily solved by making use of the implemented normalizations (in fact, compute_bunch_normalized_matrices precisely does the desired transformation, SCConv is the model defined in that very same paper).
Two important concerns about
SCConv
simplicial model:The text was updated successfully, but these errors were encountered: