Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCConv needs a full revision #253

Open
2 tasks
gbg141 opened this issue Nov 14, 2023 · 2 comments
Open
2 tasks

SCConv needs a full revision #253

gbg141 opened this issue Nov 14, 2023 · 2 comments

Comments

@gbg141
Copy link
Member

gbg141 commented Nov 14, 2023

Two important concerns about SCConv simplicial model:

  • Implementation of normalization: The original paper consider normalized incidence and adjacency matrices, but the proposed normalization procedure in the tutorial does not work. Currently, the model runs without any normalization.
  • Improving readability: The notation of incidence and adjacency matrices is difficult to follow; this needs to be carefully revised for the model to be further used.
@mhajij
Copy link
Member

mhajij commented Nov 14, 2023

@gbg141
I have started point 1 above,

pyt-team/TopoNetX#176

please take a look at that PR, and let me know if other normalization are needed. I am going to work on the suggestions in that PR in there today and if you have more suggestions let me know.

@gbg141
Copy link
Member Author

gbg141 commented Nov 15, 2023

Really nice and practical addition to TopoNetX! For sure point 1 can be easily solved by making use of the implemented normalizations (in fact, compute_bunch_normalized_matrices precisely does the desired transformation, SCConv is the model defined in that very same paper).

No further suggestions from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants