From ea12494cd30e203f043630ea347be17b8baa88bb Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 15:23:44 +0300 Subject: [PATCH 01/13] Create LICENSE --- LICENSE | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 LICENSE diff --git a/LICENSE b/LICENSE new file mode 100644 index 0000000..0084c3b --- /dev/null +++ b/LICENSE @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2025 PavelSapegin + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. From 01a3312a91544f9d92e8a1f7c6491b7b5d376b54 Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 15:25:25 +0300 Subject: [PATCH 02/13] Add .gitignore and .python-version --- .gitignore | 176 ++++++++++++++++++++++++++++++++++++++++++++++++ .python-version | 1 + 2 files changed, 177 insertions(+) create mode 100644 .gitignore create mode 100644 .python-version diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..ad4a1f1 --- /dev/null +++ b/.gitignore @@ -0,0 +1,176 @@ +# Created by https://www.toptal.com/developers/gitignore/api/python +# Edit at https://www.toptal.com/developers/gitignore?templates=python + +### Python ### +# Byte-compiled / optimized / DLL files +__pycache__/ +*.py[cod] +*$py.class + +# C extensions +*.so + +# Distribution / packaging +.Python +build/ +develop-eggs/ +dist/ +downloads/ +eggs/ +.eggs/ +lib/ +lib64/ +parts/ +sdist/ +var/ +wheels/ +share/python-wheels/ +*.egg-info/ +.installed.cfg +*.egg +MANIFEST + +# PyInstaller +# Usually these files are written by a python script from a template +# before PyInstaller builds the exe, so as to inject date/other infos into it. +*.manifest +*.spec + +# Installer logs +pip-log.txt +pip-delete-this-directory.txt + +# Unit test / coverage reports +htmlcov/ +.tox/ +.nox/ +.coverage +.coverage.* +.cache +nosetests.xml +coverage.xml +*.cover +*.py,cover +.hypothesis/ +.pytest_cache/ +cover/ + +# Translations +*.mo +*.pot + +# Django stuff: +*.log +local_settings.py +db.sqlite3 +db.sqlite3-journal + +# Flask stuff: +instance/ +.webassets-cache + +# Scrapy stuff: +.scrapy + +# Sphinx documentation +docs/_build/ + +# PyBuilder +.pybuilder/ +target/ + +# Jupyter Notebook +.ipynb_checkpoints + +# IPython +profile_default/ +ipython_config.py + +# pyenv +# For a library or package, you might want to ignore these files since the code is +# intended to run in multiple environments; otherwise, check them in: +# .python-version + +# pipenv +# According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control. +# However, in case of collaboration, if having platform-specific dependencies or dependencies +# having no cross-platform support, pipenv may install dependencies that don't work, or not +# install all needed dependencies. +#Pipfile.lock + +# poetry +# Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control. +# This is especially recommended for binary packages to ensure reproducibility, and is more +# commonly ignored for libraries. +# https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control +#poetry.lock + +# pdm +# Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control. +#pdm.lock +# pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it +# in version control. +# https://pdm.fming.dev/#use-with-ide +.pdm.toml + +# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm +__pypackages__/ + +# Celery stuff +celerybeat-schedule +celerybeat.pid + +# SageMath parsed files +*.sage.py + +# Environments +.env +.venv +env/ +venv/ +ENV/ +env.bak/ +venv.bak/ + +# Spyder project settings +.spyderproject +.spyproject + +# Rope project settings +.ropeproject + +# mkdocs documentation +/site + +# mypy +.mypy_cache/ +.dmypy.json +dmypy.json + +# Pyre type checker +.pyre/ + +# pytype static type analyzer +.pytype/ + +# Cython debug symbols +cython_debug/ + +# PyCharm +# JetBrains specific template is maintained in a separate JetBrains.gitignore that can +# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore +# and can be added to the global gitignore or merged into this file. For a more nuclear +# option (not recommended) you can uncomment the following to ignore the entire idea folder. +#.idea/ + +### Python Patch ### +# Poetry local configuration file - https://python-poetry.org/docs/configuration/#local-configuration +poetry.toml + +# ruff +.ruff_cache/ + +# LSP config files +pyrightconfig.json + +# End of https://www.toptal.com/developers/gitignore/api/python diff --git a/.python-version b/.python-version new file mode 100644 index 0000000..4e0cbc8 --- /dev/null +++ b/.python-version @@ -0,0 +1 @@ +Python 3.12.3 From 5b028d4d93db367747535bbfdb7190917f54869d Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 15:40:53 +0300 Subject: [PATCH 03/13] Add situation when power is zero or negative --- src/fast_pow.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/fast_pow.py b/src/fast_pow.py index 1ba1dc1..1359f1e 100644 --- a/src/fast_pow.py +++ b/src/fast_pow.py @@ -1,6 +1,14 @@ def fastPow(number, power): result = number + flag = False + + if power == 0: + return result + if power < 1: + power = abs(power) + flag = True + while power != 1: result *= result power = power // 2 - return result + return result if not flag else 1 / result From 8dc1a74bd1c4c9b6857193bc26774c9aedf7d58a Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 15:47:18 +0300 Subject: [PATCH 04/13] Add raises for not integernumbers --- src/fast_pow.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/fast_pow.py b/src/fast_pow.py index 1359f1e..d608483 100644 --- a/src/fast_pow.py +++ b/src/fast_pow.py @@ -1,7 +1,10 @@ -def fastPow(number, power): +def fast_pow(number, power): result = number flag = False + if not isinstance(result,int) or not isinstance(power,int): + raise ValueError("Please, input only integers numbers") + if power == 0: return result if power < 1: From dfd35acb33cb1e141f9cc73368b83d7e38624634 Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 15:52:49 +0300 Subject: [PATCH 05/13] Add test for zero and error situation for fast_pow --- test/test_fast_pow.py | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/test/test_fast_pow.py b/test/test_fast_pow.py index 5e4aebd..31747cd 100644 --- a/test/test_fast_pow.py +++ b/test/test_fast_pow.py @@ -1,9 +1,19 @@ -from src.fast_pow import fastPow +from src.fast_pow import fast_pow +import pytest def test_two_power_two(): - assert fastPow(2, 2) == 4 + assert fast_pow(2, 2) == 4 def test_negative(): - assert fastPow(-1, 4) == 1 + assert fast_pow(-1, 4) == 1 + + +def test_zero(): + assert fast_pow(123, 0) == 123 + + +def test_false(): + with pytest.raises(ValueError): + fast_pow("a", -1.232) From 5b81142da7a4b053cae268392158c1ec0ff8422c Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 16:07:45 +0300 Subject: [PATCH 06/13] Fix luhn (change condition to false) --- src/luhn.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/luhn.py b/src/luhn.py index 11d993c..ee59f30 100644 --- a/src/luhn.py +++ b/src/luhn.py @@ -4,11 +4,14 @@ def luhnСheck(cardNumber): parity = (len(digits))%2 total = 0 for i in range(len(digits)): - if i % 2 == parity: + if i % 2 != parity: doubled = digits[i] * 2 if doubled > 9: doubled -= 9 total += doubled else: total += digits[i] + return (total + control) % 10 == 0 + +print(luhnСheck(4561261212345467)) From ff55e0590a618e27d6c80b2e404da7b12752cb2f Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 16:09:46 +0300 Subject: [PATCH 07/13] Add checking for normal number --- src/luhn.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/luhn.py b/src/luhn.py index ee59f30..1aa4b49 100644 --- a/src/luhn.py +++ b/src/luhn.py @@ -1,7 +1,10 @@ def luhnСheck(cardNumber): digits = [int(d) for d in str(cardNumber) if d.isdigit()] + if len(digits) == 0: + raise ValueError("Please, input only integers") + control = digits.pop() - parity = (len(digits))%2 + parity = (len(digits)) % 2 total = 0 for i in range(len(digits)): if i % 2 != parity: @@ -11,7 +14,5 @@ def luhnСheck(cardNumber): total += doubled else: total += digits[i] - - return (total + control) % 10 == 0 -print(luhnСheck(4561261212345467)) + return (total + control) % 10 == 0 From 4d464ba6045ce0a10c2a6419e4fdeb73521159a7 Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 16:23:54 +0300 Subject: [PATCH 08/13] Rewrite test_good (correcinput) and write test for incorrect input --- test/test_luhn.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/test/test_luhn.py b/test/test_luhn.py index 1c021a2..5daaa2c 100644 --- a/test/test_luhn.py +++ b/test/test_luhn.py @@ -1,9 +1,15 @@ -from src.luhn import luhnСheck +import pytest +from src.luhn import luhnCheck def test_good(): - assert luhnСheck("8571 2612 1234 5467") + assert luhnCheck("3571 2612 1234 5467") def test_bad(): - assert not luhnСheck("4561 2612 1234 5463") \ No newline at end of file + assert not luhnCheck("4561 2612 1234 5463") + + +def test_incorrect(): + with pytest.raises(ValueError): + luhnCheck("aaaaa") From fc6159173fd3052f41e4cebdc2ba072b6f72a2e0 Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 16:25:01 +0300 Subject: [PATCH 09/13] Change name of functionf luhnCheck to latin alphabet --- src/luhn.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/luhn.py b/src/luhn.py index 1aa4b49..731ba42 100644 --- a/src/luhn.py +++ b/src/luhn.py @@ -1,4 +1,4 @@ -def luhnСheck(cardNumber): +def luhnCheck(cardNumber): digits = [int(d) for d in str(cardNumber) if d.isdigit()] if len(digits) == 0: raise ValueError("Please, input only integers") From f892786a8aea432623898afb99208d9650491b39 Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 16:42:33 +0300 Subject: [PATCH 10/13] Change name for function luhn_check --- test/test_luhn.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test_luhn.py b/test/test_luhn.py index 5daaa2c..1a8c3f5 100644 --- a/test/test_luhn.py +++ b/test/test_luhn.py @@ -1,15 +1,15 @@ import pytest -from src.luhn import luhnCheck +from src.luhn import luhn_check def test_good(): - assert luhnCheck("3571 2612 1234 5467") + assert luhn_check("3571 2612 1234 5467") def test_bad(): - assert not luhnCheck("4561 2612 1234 5463") + assert not luhn_check("4561 2612 1234 5463") def test_incorrect(): with pytest.raises(ValueError): - luhnCheck("aaaaa") + luhn_check("aaaaa") From 920f630046147092972d9e1af126f944338b9c5e Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 16:48:20 +0300 Subject: [PATCH 11/13] Realize app to checking number for users --- src/luhn.py | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/luhn.py b/src/luhn.py index 731ba42..7e3de29 100644 --- a/src/luhn.py +++ b/src/luhn.py @@ -1,7 +1,9 @@ -def luhnCheck(cardNumber): +def luhn_check(cardNumber): digits = [int(d) for d in str(cardNumber) if d.isdigit()] - if len(digits) == 0: - raise ValueError("Please, input only integers") + + if len(digits) == 0 or \ + any(ch not in "0123456789 " for ch in str(cardNumber)): + raise ValueError("Please, only input integers") control = digits.pop() parity = (len(digits)) % 2 @@ -16,3 +18,16 @@ def luhnCheck(cardNumber): total += digits[i] return (total + control) % 10 == 0 + +if __name__ == "__main__": + while True: + inpt = input("Enter number of your card:") + if inpt == "-1": + print("Goodbye!") + break + try: + res = luhn_check(inpt) + print("correct" if res else "incorrect") + except: + print("Please,try again,\nEnter only integer positive numbers") + From 20c7298d28a606eff46a8771a27c23b487845488 Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 16:49:19 +0300 Subject: [PATCH 12/13] Add oneline in the end of files --- test/test_luhn.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_luhn.py b/test/test_luhn.py index 1a8c3f5..f09d9b7 100644 --- a/test/test_luhn.py +++ b/test/test_luhn.py @@ -13,3 +13,4 @@ def test_bad(): def test_incorrect(): with pytest.raises(ValueError): luhn_check("aaaaa") + From ddadb635782776fc9f64551ab248b1f3507e923c Mon Sep 17 00:00:00 2001 From: PavelSapegin Date: Mon, 27 Oct 2025 16:54:18 +0300 Subject: [PATCH 13/13] Change ruff --- .github/workflows/ruff.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/ruff.yml b/.github/workflows/ruff.yml index 164630d..49018a0 100644 --- a/.github/workflows/ruff.yml +++ b/.github/workflows/ruff.yml @@ -6,3 +6,14 @@ jobs: steps: - uses: actions/checkout@v4 - uses: astral-sh/ruff-action@v3 + + - name: Set up Python + uses: actions/setup-python@v5 + with: + python-version: '3.x' + + - name: Install Ruff + run: pip install ruff + + - name: Run Ruff + run: ruff check .