From 25f8f8b2227c7f9d366f3786295ad85cdecc90d2 Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov <138282459+energyc0@users.noreply.github.com> Date: Thu, 23 Oct 2025 13:45:58 +0300 Subject: [PATCH 01/17] Create LICENSE --- LICENSE | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 LICENSE diff --git a/LICENSE b/LICENSE new file mode 100644 index 0000000..531fe4d --- /dev/null +++ b/LICENSE @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2025 Maxim Gavrilov + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. From fe92c2913bd75b4da7e4deaddc2420d9c6ee212b Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 13:56:57 +0300 Subject: [PATCH 02/17] Changed function name and improved functionality fast_pow() --- src/fast_pow.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/fast_pow.py b/src/fast_pow.py index 1ba1dc1..3fa87b0 100644 --- a/src/fast_pow.py +++ b/src/fast_pow.py @@ -1,6 +1,2 @@ -def fastPow(number, power): - result = number - while power != 1: - result *= result - power = power // 2 - return result +def fast_pow(number, power): + return number ** power From db05ae67f188e45ad146d742b768d1281fc2e207 Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 13:57:27 +0300 Subject: [PATCH 03/17] changed function name --- src/luhn.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/luhn.py b/src/luhn.py index 11d993c..e978d51 100644 --- a/src/luhn.py +++ b/src/luhn.py @@ -1,4 +1,4 @@ -def luhnСheck(cardNumber): +def luhn_check(cardNumber): digits = [int(d) for d in str(cardNumber) if d.isdigit()] control = digits.pop() parity = (len(digits))%2 From 9f6aae0b63d504e299e729ae4a8dcabbe6547c88 Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 13:58:32 +0300 Subject: [PATCH 04/17] Changed tests according to new function names, added some fast_pow() tests. --- test/test_fast_pow.py | 20 +++++++++++++++++--- test/test_luhn.py | 6 +++--- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/test/test_fast_pow.py b/test/test_fast_pow.py index 5e4aebd..06d0bf5 100644 --- a/test/test_fast_pow.py +++ b/test/test_fast_pow.py @@ -1,9 +1,23 @@ -from src.fast_pow import fastPow +from src.fast_pow import fast_pow def test_two_power_two(): - assert fastPow(2, 2) == 4 + assert fast_pow(2, 2) == 4 def test_negative(): - assert fastPow(-1, 4) == 1 + assert fast_pow(-1, 4) == 1 + assert fast_pow(-2, 3) == -8 + +def test_negative_power(): + assert fast_pow(5,-1) == 0.2 + assert fast_pow(10, -2) == 0.01 + assert fast_pow(77, -5) == 77**(-5) + + assert fast_pow(-0.2, -2) == 25 + assert fast_pow(-0.2, -1) == 5 + +def edge_cases(): + assert fast_pow(1100101, 0) == 1 + assert fast_pow(-13, 0) == 1 + assert fast_pow(111, 0) == 1 diff --git a/test/test_luhn.py b/test/test_luhn.py index 1c021a2..7014bb2 100644 --- a/test/test_luhn.py +++ b/test/test_luhn.py @@ -1,9 +1,9 @@ -from src.luhn import luhnСheck +from src.luhn import luhn_check def test_good(): - assert luhnСheck("8571 2612 1234 5467") + assert luhn_check("8571 2612 1234 5467") def test_bad(): - assert not luhnСheck("4561 2612 1234 5463") \ No newline at end of file + assert not luhn_check("4561 2612 1234 5463") \ No newline at end of file From 2c797573ff2288b46e40b33b7c08981824e12f44 Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 14:00:30 +0300 Subject: [PATCH 05/17] Added .gitignore file --- .gitignore | 188 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 188 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..1af57fa --- /dev/null +++ b/.gitignore @@ -0,0 +1,188 @@ +# Created by https://www.toptal.com/developers/gitignore/api/venv,python +# Edit at https://www.toptal.com/developers/gitignore?templates=venv,python + +### Python ### +# Byte-compiled / optimized / DLL files +__pycache__/ +*.py[cod] +*$py.class + +# C extensions +*.so + +# Distribution / packaging +.Python +build/ +develop-eggs/ +dist/ +downloads/ +eggs/ +.eggs/ +lib/ +lib64/ +parts/ +sdist/ +var/ +wheels/ +share/python-wheels/ +*.egg-info/ +.installed.cfg +*.egg +MANIFEST + +# PyInstaller +# Usually these files are written by a python script from a template +# before PyInstaller builds the exe, so as to inject date/other infos into it. +*.manifest +*.spec + +# Installer logs +pip-log.txt +pip-delete-this-directory.txt + +# Unit test / coverage reports +htmlcov/ +.tox/ +.nox/ +.coverage +.coverage.* +.cache +nosetests.xml +coverage.xml +*.cover +*.py,cover +.hypothesis/ +.pytest_cache/ +cover/ + +# Translations +*.mo +*.pot + +# Django stuff: +*.log +local_settings.py +db.sqlite3 +db.sqlite3-journal + +# Flask stuff: +instance/ +.webassets-cache + +# Scrapy stuff: +.scrapy + +# Sphinx documentation +docs/_build/ + +# PyBuilder +.pybuilder/ +target/ + +# Jupyter Notebook +.ipynb_checkpoints + +# IPython +profile_default/ +ipython_config.py + +# pyenv +# For a library or package, you might want to ignore these files since the code is +# intended to run in multiple environments; otherwise, check them in: +# .python-version + +# pipenv +# According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control. +# However, in case of collaboration, if having platform-specific dependencies or dependencies +# having no cross-platform support, pipenv may install dependencies that don't work, or not +# install all needed dependencies. +#Pipfile.lock + +# poetry +# Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control. +# This is especially recommended for binary packages to ensure reproducibility, and is more +# commonly ignored for libraries. +# https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control +#poetry.lock + +# pdm +# Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control. +#pdm.lock +# pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it +# in version control. +# https://pdm.fming.dev/#use-with-ide +.pdm.toml + +# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm +__pypackages__/ + +# Celery stuff +celerybeat-schedule +celerybeat.pid + +# SageMath parsed files +*.sage.py + +# Environments +.env +.venv +env/ +venv/ +ENV/ +env.bak/ +venv.bak/ + +# Spyder project settings +.spyderproject +.spyproject + +# Rope project settings +.ropeproject + +# mkdocs documentation +/site + +# mypy +.mypy_cache/ +.dmypy.json +dmypy.json + +# Pyre type checker +.pyre/ + +# pytype static type analyzer +.pytype/ + +# Cython debug symbols +cython_debug/ + +# PyCharm +# JetBrains specific template is maintained in a separate JetBrains.gitignore that can +# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore +# and can be added to the global gitignore or merged into this file. For a more nuclear +# option (not recommended) you can uncomment the following to ignore the entire idea folder. +#.idea/ + +### Python Patch ### +# Poetry local configuration file - https://python-poetry.org/docs/configuration/#local-configuration +poetry.toml + +# ruff +.ruff_cache/ + +# LSP config files +pyrightconfig.json + +### venv ### +# Virtualenv +# http://iamzed.com/2009/05/07/a-primer-on-virtualenv/ +[Bb]in +[Ii]nclude +[Ll]ib +[Ll]ib64 +[Ll]ocal +[Ss]cripts +pyvenv.cfg +pip-selfcheck.json + +# End of https://www.toptal.com/developers/gitignore/api/venv,python From e7a4dfc2ec501e32dea6668c583d46ac9bfb5722 Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 14:05:59 +0300 Subject: [PATCH 06/17] Added epsilon for floating numbers --- test/test_fast_pow.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/test/test_fast_pow.py b/test/test_fast_pow.py index 06d0bf5..4a04a94 100644 --- a/test/test_fast_pow.py +++ b/test/test_fast_pow.py @@ -1,6 +1,5 @@ from src.fast_pow import fast_pow - def test_two_power_two(): assert fast_pow(2, 2) == 4 @@ -10,12 +9,14 @@ def test_negative(): assert fast_pow(-2, 3) == -8 def test_negative_power(): - assert fast_pow(5,-1) == 0.2 - assert fast_pow(10, -2) == 0.01 - assert fast_pow(77, -5) == 77**(-5) + epsilon = 1e-8 + + assert fast_pow(5,-1) - 0.2 <= epsilon + assert fast_pow(10, -2) - 0.01 <= epsilon + assert fast_pow(77, -5) - 77**(-5) <= epsilon - assert fast_pow(-0.2, -2) == 25 - assert fast_pow(-0.2, -1) == 5 + assert fast_pow(-0.2, -2) - 25 <= epsilon + assert fast_pow(-0.2, -1) - 5 <= epsilon def edge_cases(): assert fast_pow(1100101, 0) == 1 From f38340a56705c6585d7b9cb96d3a2aec717a44ce Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 14:07:04 +0300 Subject: [PATCH 07/17] Formatted code with ruff --- src/fast_pow.py | 2 +- src/luhn.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/fast_pow.py b/src/fast_pow.py index 3fa87b0..730e720 100644 --- a/src/fast_pow.py +++ b/src/fast_pow.py @@ -1,2 +1,2 @@ def fast_pow(number, power): - return number ** power + return number**power diff --git a/src/luhn.py b/src/luhn.py index e978d51..c5e85ca 100644 --- a/src/luhn.py +++ b/src/luhn.py @@ -1,7 +1,7 @@ -def luhn_check(cardNumber): - digits = [int(d) for d in str(cardNumber) if d.isdigit()] +def luhn_check(card_number): + digits = [int(d) for d in str(card_number) if d.isdigit()] control = digits.pop() - parity = (len(digits))%2 + parity = (len(digits)) % 2 total = 0 for i in range(len(digits)): if i % 2 == parity: From ca5ad895bb6e6e16121df271ff78c57e66705846 Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 14:09:55 +0300 Subject: [PATCH 08/17] Formatted code with ruff --- test/test_fast_pow.py | 7 +++++-- test/test_luhn.py | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/test/test_fast_pow.py b/test/test_fast_pow.py index 4a04a94..be04b80 100644 --- a/test/test_fast_pow.py +++ b/test/test_fast_pow.py @@ -1,5 +1,6 @@ from src.fast_pow import fast_pow + def test_two_power_two(): assert fast_pow(2, 2) == 4 @@ -8,16 +9,18 @@ def test_negative(): assert fast_pow(-1, 4) == 1 assert fast_pow(-2, 3) == -8 + def test_negative_power(): epsilon = 1e-8 - assert fast_pow(5,-1) - 0.2 <= epsilon + assert fast_pow(5, -1) - 0.2 <= epsilon assert fast_pow(10, -2) - 0.01 <= epsilon - assert fast_pow(77, -5) - 77**(-5) <= epsilon + assert fast_pow(77, -5) - 77 ** (-5) <= epsilon assert fast_pow(-0.2, -2) - 25 <= epsilon assert fast_pow(-0.2, -1) - 5 <= epsilon + def edge_cases(): assert fast_pow(1100101, 0) == 1 assert fast_pow(-13, 0) == 1 diff --git a/test/test_luhn.py b/test/test_luhn.py index 7014bb2..d042e3d 100644 --- a/test/test_luhn.py +++ b/test/test_luhn.py @@ -6,4 +6,4 @@ def test_good(): def test_bad(): - assert not luhn_check("4561 2612 1234 5463") \ No newline at end of file + assert not luhn_check("4561 2612 1234 5463") From 9009e4ecf9ec4e0aaae2dafff0242a41ae7661cf Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 14:14:56 +0300 Subject: [PATCH 09/17] Added tests for roots and added prefix 'test_' to edge_cases(). --- test/test_fast_pow.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test/test_fast_pow.py b/test/test_fast_pow.py index be04b80..1477329 100644 --- a/test/test_fast_pow.py +++ b/test/test_fast_pow.py @@ -21,7 +21,13 @@ def test_negative_power(): assert fast_pow(-0.2, -1) - 5 <= epsilon -def edge_cases(): +def test_edge_cases(): assert fast_pow(1100101, 0) == 1 assert fast_pow(-13, 0) == 1 assert fast_pow(111, 0) == 1 + + +def test_roots(): + assert fast_pow(9, 0.5) == 3 + assert fast_pow(8, 1 / 3) == 2 + assert fast_pow(64, 1 / 6) == 2 From 7e57f322aae286017f7c7331e2693b357f9bf189 Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 14:33:37 +0300 Subject: [PATCH 10/17] Fixed bugs in luhn_check() card_number must be a string, added control number checking --- src/luhn.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/luhn.py b/src/luhn.py index c5e85ca..a50004b 100644 --- a/src/luhn.py +++ b/src/luhn.py @@ -1,14 +1,15 @@ -def luhn_check(card_number): - digits = [int(d) for d in str(card_number) if d.isdigit()] +def luhn_check(card_number: str): + digits = [int(d) for d in card_number if d.isdigit()] control = digits.pop() parity = (len(digits)) % 2 total = 0 for i in range(len(digits)): - if i % 2 == parity: + if (i + 1) % 2 == parity: doubled = digits[i] * 2 if doubled > 9: doubled -= 9 total += doubled else: total += digits[i] - return (total + control) % 10 == 0 + total += control + return total % 10 == 0 and total // 10 == control From 351ba7472a2b307d9bcff4ea5ba46728d09bffe3 Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 14:38:21 +0300 Subject: [PATCH 11/17] Fixed tests bugs Changed testscase because it was invalid. --- test/test_luhn.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/test_luhn.py b/test/test_luhn.py index d042e3d..5aad6cb 100644 --- a/test/test_luhn.py +++ b/test/test_luhn.py @@ -2,8 +2,11 @@ def test_good(): - assert luhn_check("8571 2612 1234 5467") + assert luhn_check("8571 2612 1234 5466") + assert luhn_check("4 5 6 1 2 6 1 2 1 2 3 4 5 5 6 6") def test_bad(): assert not luhn_check("4561 2612 1234 5463") + assert not luhn_check("4 5 6 1 2 6 1 2 1 2 3 4 5 4 6 4") + assert not luhn_check("4 5 6 1 2 6 1 2 1 2 3 4 5 4 6 7") From 8cbbbfbec090b9b1844107a353171b2ee4308825 Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 14:51:46 +0300 Subject: [PATCH 12/17] Added interactive luhn card checking algorithm. --- src/luhn.py | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/src/luhn.py b/src/luhn.py index a50004b..a5c2ddf 100644 --- a/src/luhn.py +++ b/src/luhn.py @@ -13,3 +13,32 @@ def luhn_check(card_number: str): total += digits[i] total += control return total % 10 == 0 and total // 10 == control + + +def luhn_interactive(): + def check_valid_card(card): + return all(x.isspace() or x.isdigit() for x in card) + + while True: + try: + user_input = input("Write card number or -1 to quit: ") + + if user_input == "-1": + break + + if not check_valid_card(user_input): + raise Exception("You didn't enter a card.") + + if luhn_check(user_input): + print("Your card is correct.") + else: + print("Your card is incorrect.") + except EOFError: + break + except Exception as e: + print(e) + print("Bye bye!") + + +if __name__ == "__main__": + luhn_interactive() From 1e998a50b6bab173767d01d8eb96b01b084eb34a Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 15:04:58 +0300 Subject: [PATCH 13/17] luhn_check() not raises ValueError Added some tests for exception checking. --- src/luhn.py | 24 +++++++++++++++++------- test/test_luhn.py | 11 +++++++++++ 2 files changed, 28 insertions(+), 7 deletions(-) diff --git a/src/luhn.py b/src/luhn.py index a5c2ddf..7676dd4 100644 --- a/src/luhn.py +++ b/src/luhn.py @@ -1,4 +1,16 @@ def luhn_check(card_number: str): + """ + This is luhn checking algorithm. + It check whether the card is correct. + card_number must be a valid string containing digits and spaces. + It raises ValueError if card_number is invalid. + """ + if ( + not all(x.isspace() or x.isdigit() for x in card_number) + or len(card_number) == 0 + ): + raise ValueError("The luhn algorithm did not receive a card for input.") + digits = [int(d) for d in card_number if d.isdigit()] control = digits.pop() parity = (len(digits)) % 2 @@ -16,9 +28,10 @@ def luhn_check(card_number: str): def luhn_interactive(): - def check_valid_card(card): - return all(x.isspace() or x.isdigit() for x in card) - + """ + This is command line interactive luhn checking algorithm. + User writes down a credit card and gets whether his card is correct or not. + """ while True: try: user_input = input("Write card number or -1 to quit: ") @@ -26,16 +39,13 @@ def check_valid_card(card): if user_input == "-1": break - if not check_valid_card(user_input): - raise Exception("You didn't enter a card.") - if luhn_check(user_input): print("Your card is correct.") else: print("Your card is incorrect.") except EOFError: break - except Exception as e: + except ValueError as e: print(e) print("Bye bye!") diff --git a/test/test_luhn.py b/test/test_luhn.py index 5aad6cb..d968638 100644 --- a/test/test_luhn.py +++ b/test/test_luhn.py @@ -1,3 +1,4 @@ +import pytest from src.luhn import luhn_check @@ -10,3 +11,13 @@ def test_bad(): assert not luhn_check("4561 2612 1234 5463") assert not luhn_check("4 5 6 1 2 6 1 2 1 2 3 4 5 4 6 4") assert not luhn_check("4 5 6 1 2 6 1 2 1 2 3 4 5 4 6 7") + +def test_invalid(): + with pytest.raises(ValueError): + luhn_check("abc") + + with pytest.raises(ValueError): + luhn_check("451abc") + + with pytest.raises(ValueError): + luhn_check("") From 01c7ae66cbdb9a24aa7b3c1c582061869455c3ea Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 15:06:03 +0300 Subject: [PATCH 14/17] Added comments for fast_pow() --- src/fast_pow.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/fast_pow.py b/src/fast_pow.py index 730e720..a2b2a17 100644 --- a/src/fast_pow.py +++ b/src/fast_pow.py @@ -1,2 +1,5 @@ def fast_pow(number, power): + ''' + Mega fast pow algorithm. + ''' return number**power From b4675e66802decb84bfdad54557471848fc081af Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 15:06:03 +0300 Subject: [PATCH 15/17] Added comments for fast_pow() --- src/fast_pow.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/fast_pow.py b/src/fast_pow.py index 730e720..a65f6bb 100644 --- a/src/fast_pow.py +++ b/src/fast_pow.py @@ -1,2 +1,5 @@ def fast_pow(number, power): + """ + Mega fast pow algorithm. + """ return number**power From 1f79e8d78a26a0c848af57c44cd5794c9f8d2353 Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 15:10:01 +0300 Subject: [PATCH 16/17] Fixed previous stupid commit for not resolving conflicts. --- src/fast_pow.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/fast_pow.py b/src/fast_pow.py index 74acb1f..a65f6bb 100644 --- a/src/fast_pow.py +++ b/src/fast_pow.py @@ -1,11 +1,5 @@ def fast_pow(number, power): -<<<<<<< HEAD """ Mega fast pow algorithm. """ -======= - ''' - Mega fast pow algorithm. - ''' ->>>>>>> 01c7ae66cbdb9a24aa7b3c1c582061869455c3ea return number**power From f33f4ca2679ddc51967352d05ed36732e3207566 Mon Sep 17 00:00:00 2001 From: Maxim Gavrilov Date: Thu, 23 Oct 2025 15:12:23 +0300 Subject: [PATCH 17/17] Fixed ruff checking issue. --- test/test_luhn.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_luhn.py b/test/test_luhn.py index 89a1988..a891878 100644 --- a/test/test_luhn.py +++ b/test/test_luhn.py @@ -1,4 +1,5 @@ import pytest + from src.luhn import luhn_check