From a18210952534d11493f8aff0725b1fc83bf157d7 Mon Sep 17 00:00:00 2001 From: DolzhenkoAlexa Date: Fri, 7 Nov 2025 16:40:33 +0300 Subject: [PATCH 1/7] Add MIT Lisence --- LICENSE | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 LICENSE diff --git a/LICENSE b/LICENSE new file mode 100644 index 0000000..fa8a9cb --- /dev/null +++ b/LICENSE @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2025 DolzhenkoAlexa + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. From 7d92ad9e8262218103403d8369a52d6e96c0e085 Mon Sep 17 00:00:00 2001 From: DolzhenkoAlexa Date: Fri, 7 Nov 2025 16:41:27 +0300 Subject: [PATCH 2/7] Add .gitignore with python template --- .gitignore | 202 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 202 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..fa61663 --- /dev/null +++ b/.gitignore @@ -0,0 +1,202 @@ +# Byte-compiled / optimized / DLL files +__pycache__/ +*.py[codz] +*$py.class + +# C extensions +*.so + +# Distribution / packaging +.Python +build/ +develop-eggs/ +dist/ +downloads/ +eggs/ +.eggs/ +lib/ +lib64/ +parts/ +sdist/ +var/ +wheels/ +share/python-wheels/ +*.egg-info/ +.installed.cfg +*.egg +MANIFEST + +# PyInstaller +# Usually these files are written by a python script from a template +# before PyInstaller builds the exe, so as to inject date/other infos into it. +*.manifest +*.spec + +# Installer logs +pip-log.txt +pip-delete-this-directory.txt + +# Unit test / coverage reports +htmlcov/ +.tox/ +.nox/ +.coverage +.coverage.* +.cache +nosetests.xml +coverage.xml +*.cover +*.py.cover +.hypothesis/ +.pytest_cache/ +cover/ + +# Translations +*.mo +*.pot + +# Django stuff: +*.log +local_settings.py +db.sqlite3 +db.sqlite3-journal + +# Flask stuff: +instance/ +.webassets-cache + +# Scrapy stuff: +.scrapy + +# Sphinx documentation +docs/_build/ + +# PyBuilder +.pybuilder/ +target/ + +# Jupyter Notebook +.ipynb_checkpoints + +# IPython +profile_default/ +ipython_config.py + +# pyenv +# For a library or package, you might want to ignore these files since the code is +# intended to run in multiple environments; otherwise, check them in: +# .python-version + +# pipenv +# According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control. +# However, in case of collaboration, if having platform-specific dependencies or dependencies +# having no cross-platform support, pipenv may install dependencies that don't work, or not +# install all needed dependencies. +#Pipfile.lock + +# UV +# Similar to Pipfile.lock, it is generally recommended to include uv.lock in version control. +# This is especially recommended for binary packages to ensure reproducibility, and is more +# commonly ignored for libraries. +#uv.lock + +# poetry +# Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control. +# This is especially recommended for binary packages to ensure reproducibility, and is more +# commonly ignored for libraries. +# https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control +#poetry.lock +#poetry.toml + +# pdm +# Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control. +# pdm recommends including project-wide configuration in pdm.toml, but excluding .pdm-python. +# https://pdm-project.org/en/latest/usage/project/#working-with-version-control +#pdm.lock +#pdm.toml +.pdm-python +.pdm-build/ + +# pixi +# Similar to Pipfile.lock, it is generally recommended to include pixi.lock in version control. +#pixi.lock +# Pixi creates a virtual environment in the .pixi directory, just like venv module creates one +# in the .venv directory. It is recommended not to include this directory in version control. +.pixi + +# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm +__pypackages__/ + +# Celery stuff +celerybeat-schedule +celerybeat.pid + +# SageMath parsed files +*.sage.py + +# Environments +.env +.envrc +.venv +env/ +venv/ +ENV/ +env.bak/ +venv.bak/ + +# Spyder project settings +.spyderproject +.spyproject + +# Rope project settings +.ropeproject + +# mkdocs documentation +/site + +# mypy +.mypy_cache/ +.dmypy.json +dmypy.json + +# Pyre type checker +.pyre/ + +# pytype static type analyzer +.pytype/ + +# Cython debug symbols +cython_debug/ + +# PyCharm +# JetBrains specific template is maintained in a separate JetBrains.gitignore that can +# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore +# and can be added to the global gitignore or merged into this file. For a more nuclear +# option (not recommended) you can uncomment the following to ignore the entire idea folder. +#.idea/ + +# Abstra +# Abstra is an AI-powered process automation framework. +# Ignore directories containing user credentials, local state, and settings. +# Learn more at https://abstra.io/docs +.abstra/ + +# Visual Studio Code +# Visual Studio Code specific template is maintained in a separate VisualStudioCode.gitignore +# that can be found at https://github.com/github/gitignore/blob/main/Global/VisualStudioCode.gitignore +# and can be added to the global gitignore or merged into this file. However, if you prefer, +# you could uncomment the following to ignore the entire vscode folder +# .vscode/ + +# Ruff stuff: +.ruff_cache/ + +# PyPI configuration file +.pypirc + +# Cursor +# Cursor is an AI-powered code editor. `.cursorignore` specifies files/directories to +# exclude from AI features like autocomplete and code analysis. Recommended for sensitive data +# refer to https://docs.cursor.com/context/ignore-files +.cursorignore +.cursorindexingignore \ No newline at end of file From 31d8a4c278a2970d9e66e2849e128c345230c721 Mon Sep 17 00:00:00 2001 From: DolzhenkoAlexa Date: Fri, 7 Nov 2025 16:42:45 +0300 Subject: [PATCH 3/7] Add .python-version --- .python-version | 1 + 1 file changed, 1 insertion(+) create mode 100644 .python-version diff --git a/.python-version b/.python-version new file mode 100644 index 0000000..77fdc6b --- /dev/null +++ b/.python-version @@ -0,0 +1 @@ +3.13.0 \ No newline at end of file From 14860c135707f4bbb0b86b1bc3361439d738ac36 Mon Sep 17 00:00:00 2001 From: DolzhenkoAlexa Date: Fri, 7 Nov 2025 16:50:35 +0300 Subject: [PATCH 4/7] Code style fix because of CL: rename files and functions to snake_case, ruff checks were passed --- src/bin_search.py | 2 +- src/check_sum.py | 14 ++++++++++++++ src/checksum.py | 14 -------------- test/test_check_sum.py | 9 +++++++++ test/test_checksum.py | 9 --------- 5 files changed, 24 insertions(+), 24 deletions(-) create mode 100644 src/check_sum.py delete mode 100644 src/checksum.py create mode 100644 test/test_check_sum.py delete mode 100644 test/test_checksum.py diff --git a/src/bin_search.py b/src/bin_search.py index 713abfc..d878d33 100644 --- a/src/bin_search.py +++ b/src/bin_search.py @@ -1,4 +1,4 @@ -def binSearch(xs: list[int], x: int): +def bin_search(xs: list[int], x: int): left, right = 0, len(xs) - 1 while left < right: mid = (left + right) // 2 diff --git a/src/check_sum.py b/src/check_sum.py new file mode 100644 index 0000000..e0f92cb --- /dev/null +++ b/src/check_sum.py @@ -0,0 +1,14 @@ +def modulo_11_check_sum(isbn_number: str): + + digits = [int(char) for char in isbn_number if char.isdigit()] + + check_digit = digits[-1] + + total = 0 + for i in range(len(digits) - 1): + weight = 10 + digit = digits[i] + total += digit * weight + + check_sum = total + check_digit + return check_sum % 11 == 0 diff --git a/src/checksum.py b/src/checksum.py deleted file mode 100644 index 74b4fb0..0000000 --- a/src/checksum.py +++ /dev/null @@ -1,14 +0,0 @@ -def modulo11Checksum(ISBNNumber: str): - - digits = [int(char) for char in ISBNNumber if char.isdigit()] - - checkDigit = digits[-1] - - total = 0 - for i in range(len(digits) - 1): - weight = 10 - digit = digits[i] - total += digit * weight - - checksum = total + checkDigit - return checksum % 11 == 0 diff --git a/test/test_check_sum.py b/test/test_check_sum.py new file mode 100644 index 0000000..170f724 --- /dev/null +++ b/test/test_check_sum.py @@ -0,0 +1,9 @@ +from src.check_sum import modulo_11_сheck_sum + + +def test_good(): + assert modulo_11_сheck_sum("2-266-11156-8") + + +def test_bad(): + assert not modulo_11_сheck_sum("2-266-11156-3") diff --git a/test/test_checksum.py b/test/test_checksum.py deleted file mode 100644 index f64a64c..0000000 --- a/test/test_checksum.py +++ /dev/null @@ -1,9 +0,0 @@ -from src.checksum import modulo11Checksum - - -def test_good(): - assert modulo11Checksum("2-266-11156-8") - - -def test_bad(): - assert not modulo11Checksum("2-266-11156-3") From ca7e53efaa31cef2563cb1d9f7a6265da74b5a87 Mon Sep 17 00:00:00 2001 From: DolzhenkoAlexa Date: Fri, 7 Nov 2025 17:07:09 +0300 Subject: [PATCH 5/7] Bug fix: when list is empty, when last element is not on its place --- src/bin_search.py | 5 ++++- test/test_bin_search.py | 30 ++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 test/test_bin_search.py diff --git a/src/bin_search.py b/src/bin_search.py index d878d33..a5bef7f 100644 --- a/src/bin_search.py +++ b/src/bin_search.py @@ -1,6 +1,9 @@ def bin_search(xs: list[int], x: int): + if not xs: # Обработка случая с пустым списком + return -1 + left, right = 0, len(xs) - 1 - while left < right: + while left <= right: # Изменено с < на <= для обработки последнего элемента mid = (left + right) // 2 if xs[mid] == x: return mid diff --git a/test/test_bin_search.py b/test/test_bin_search.py new file mode 100644 index 0000000..0d514cf --- /dev/null +++ b/test/test_bin_search.py @@ -0,0 +1,30 @@ +from src.bin_search import bin_search + + +def test_middle(): + assert bin_search([1, 2, 3, 4, 5], 4) == 3 + + +def test_start(): + assert bin_search([1, 2, 3, 4], 2) == 1 + + +def test_not_in_list(): + assert bin_search([1, 2, 3, 4], 5) == -1 + + + +# НОВЫЕ ТЕСТЫ ДЛЯ ИСПРАВЛЕННЫХ БАГОВ: + +#Тест для проверки пустого списка +def test_empty_list(): + assert bin_search([], 5) == -1 + + +#Тесты для проверки после исправления while +def test_single_element(): + assert bin_search([3], 3) == 0 + + +def test_last_element(): + assert bin_search([1, 2, 3], 3) == 2 From 434ccf071753bc86f9aed4c84a22f6af13ae68e7 Mon Sep 17 00:00:00 2001 From: DolzhenkoAlexa Date: Fri, 7 Nov 2025 17:20:25 +0300 Subject: [PATCH 6/7] Bug fix: when list is empty, digits checking, algoritm rewriting, new tests --- src/check_sum.py | 24 +++++++++++++++++------- test/test_check_sum.py | 21 ++++++++++++++++++--- 2 files changed, 35 insertions(+), 10 deletions(-) diff --git a/src/check_sum.py b/src/check_sum.py index e0f92cb..ae39d56 100644 --- a/src/check_sum.py +++ b/src/check_sum.py @@ -1,14 +1,24 @@ def modulo_11_check_sum(isbn_number: str): - + if not isbn_number: # Обработка случая пустой строки + return False + + # Извлекаем только цифры, без других символов digits = [int(char) for char in isbn_number if char.isdigit()] - + + # Проверяем что цифр достаточно + if len(digits) < 2: + return False + check_digit = digits[-1] - total = 0 + + # Неправильно написан алгоритм + # Веса должны уменьшаться с 10 до 1, на шаг -1 for i in range(len(digits) - 1): - weight = 10 + weight = 10 - i # Веса уменьшаются от 10 до 1 digit = digits[i] total += digit * weight - - check_sum = total + check_digit - return check_sum % 11 == 0 + + # Проверка контрольной суммы + checksum = total % 11 + return checksum == check_digit \ No newline at end of file diff --git a/test/test_check_sum.py b/test/test_check_sum.py index 170f724..5d83fb6 100644 --- a/test/test_check_sum.py +++ b/test/test_check_sum.py @@ -1,9 +1,24 @@ -from src.check_sum import modulo_11_сheck_sum +from src.check_sum import modulo_11_check_sum def test_good(): - assert modulo_11_сheck_sum("2-266-11156-8") + assert modulo_11_check_sum("2-266-11156-8") def test_bad(): - assert not modulo_11_сheck_sum("2-266-11156-3") + assert not modulo_11_check_sum("2-266-11156-3") + + +# НОВЫЕ ТЕСТЫ ДЛЯ ИСПРАВЛЕННЫХ БАГОВ: + +# Тест с пустым списком +def test_empty_string(): + assert not modulo_11_check_sum("") + +# Тест с коротким ISBN +def test_short_isbn(): + assert not modulo_11_check_sum("111") + +# Тест с неправильными символами +def test_invalid_characters(): + assert not modulo_11_check_sum("abcd!@#!") \ No newline at end of file From c7795259873f3123d6e6d408ab69b5397033997c Mon Sep 17 00:00:00 2001 From: DolzhenkoAlexa Date: Fri, 7 Nov 2025 17:21:58 +0300 Subject: [PATCH 7/7] Ruff stile fix --- src/check_sum.py | 12 ++++++------ test/test_check_sum.py | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/check_sum.py b/src/check_sum.py index ae39d56..05566e0 100644 --- a/src/check_sum.py +++ b/src/check_sum.py @@ -1,24 +1,24 @@ def modulo_11_check_sum(isbn_number: str): if not isbn_number: # Обработка случая пустой строки return False - + # Извлекаем только цифры, без других символов digits = [int(char) for char in isbn_number if char.isdigit()] - + # Проверяем что цифр достаточно if len(digits) < 2: return False - + check_digit = digits[-1] total = 0 - + # Неправильно написан алгоритм # Веса должны уменьшаться с 10 до 1, на шаг -1 for i in range(len(digits) - 1): weight = 10 - i # Веса уменьшаются от 10 до 1 digit = digits[i] total += digit * weight - + # Проверка контрольной суммы checksum = total % 11 - return checksum == check_digit \ No newline at end of file + return checksum == check_digit diff --git a/test/test_check_sum.py b/test/test_check_sum.py index 5d83fb6..4994678 100644 --- a/test/test_check_sum.py +++ b/test/test_check_sum.py @@ -21,4 +21,4 @@ def test_short_isbn(): # Тест с неправильными символами def test_invalid_characters(): - assert not modulo_11_check_sum("abcd!@#!") \ No newline at end of file + assert not modulo_11_check_sum("abcd!@#!")