From 87741544a04d4bfd748078beb4a827433874225f Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 15:50:28 +0300 Subject: [PATCH 01/15] Add ruff checking --- .github/workflows/ruff.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ruff.yml b/.github/workflows/ruff.yml index 164630d..8843b45 100644 --- a/.github/workflows/ruff.yml +++ b/.github/workflows/ruff.yml @@ -6,3 +6,4 @@ jobs: steps: - uses: actions/checkout@v4 - uses: astral-sh/ruff-action@v3 + - run: ruff check . From 26c430412aabadfb6f616d4dce2a350fee3637a6 Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 15:54:12 +0300 Subject: [PATCH 02/15] Add check lenght of number --- src/checksum.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/checksum.py b/src/checksum.py index 74b4fb0..1be6ac9 100644 --- a/src/checksum.py +++ b/src/checksum.py @@ -1,5 +1,7 @@ def modulo11Checksum(ISBNNumber: str): + assert len(ISBNNumber) == 10, "Invalid lenght" + digits = [int(char) for char in ISBNNumber if char.isdigit()] checkDigit = digits[-1] From 753c739f2b21521905badb48cefd696d3c011b64 Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 16:03:28 +0300 Subject: [PATCH 03/15] Add fix when letters inside number and take account X --- src/checksum.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/checksum.py b/src/checksum.py index 1be6ac9..61d8cd5 100644 --- a/src/checksum.py +++ b/src/checksum.py @@ -4,7 +4,13 @@ def modulo11Checksum(ISBNNumber: str): digits = [int(char) for char in ISBNNumber if char.isdigit()] - checkDigit = digits[-1] + assert (len(digits) == 9 and ISBNNumber[-1] == "X") or len(digits) == 10, "Letters in number" + + if ISBNNumber[-1] == "X": + digits += 1 + checkDigit = 10 + else: + checkDigit = digits[-1] total = 0 for i in range(len(digits) - 1): From e73df81d8228838a2eef4d6d096423a85bb4095c Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 16:05:23 +0300 Subject: [PATCH 04/15] Add correct coefficients --- src/checksum.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/checksum.py b/src/checksum.py index 61d8cd5..4a3846a 100644 --- a/src/checksum.py +++ b/src/checksum.py @@ -14,7 +14,7 @@ def modulo11Checksum(ISBNNumber: str): total = 0 for i in range(len(digits) - 1): - weight = 10 + weight = 10 - i digit = digits[i] total += digit * weight From 99d2075b02b1480c154f0837509c998b18d552f3 Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 16:17:34 +0300 Subject: [PATCH 05/15] Add an utily --- src/checksum.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/checksum.py b/src/checksum.py index 4a3846a..4fa8e7b 100644 --- a/src/checksum.py +++ b/src/checksum.py @@ -20,3 +20,17 @@ def modulo11Checksum(ISBNNumber: str): checksum = total + checkDigit return checksum % 11 == 0 + +if __name__ == "__main__": + while True: + ISBN = input("Enter ISBN: ") + if ISBN == "-1": + break + try: + result = modulo11Checksum(ISBN) + if result: + print("Correct") + else: + print("Incorrect") + except Exception as e: + print(f"{type(e).__name__}: {e}") \ No newline at end of file From fcff986a7e9145e65088a485e07b5961d4d6d688 Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 16:22:45 +0300 Subject: [PATCH 06/15] Add a fix: - account into x --- src/checksum.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/checksum.py b/src/checksum.py index 4fa8e7b..0502252 100644 --- a/src/checksum.py +++ b/src/checksum.py @@ -1,10 +1,7 @@ def modulo11Checksum(ISBNNumber: str): - - assert len(ISBNNumber) == 10, "Invalid lenght" - digits = [int(char) for char in ISBNNumber if char.isdigit()] - assert (len(digits) == 9 and ISBNNumber[-1] == "X") or len(digits) == 10, "Letters in number" + assert (len(digits) == 9 and ISBNNumber[-1] == "X") or len(digits) == 10, "Invalid lenght" if ISBNNumber[-1] == "X": digits += 1 From 738d6b9ba96bb4fa71ddffd7d8d4a8c8cf98a8be Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 16:44:07 +0300 Subject: [PATCH 07/15] Add tests for checksum.py --- test/test_checksum.py | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/test/test_checksum.py b/test/test_checksum.py index f64a64c..962c30f 100644 --- a/test/test_checksum.py +++ b/test/test_checksum.py @@ -2,8 +2,20 @@ def test_good(): - assert modulo11Checksum("2-266-11156-8") + assert modulo11Checksum("0-306-40615-2") + assert modulo11Checksum("0-306-40615-X") def test_bad(): assert not modulo11Checksum("2-266-11156-3") + + +def test_invalid_isbn10(): + assert not modulo11Checksum("1234567890") + + +def test_edge_cases(): + assert not modulo11Checksum("123") + assert not modulo11Checksum("12341222223344455") + assert not modulo11Checksum("X-305-21345-2") + assert not modulo11Checksum("3-305-21345-A") \ No newline at end of file From 63403973de84816539e3f8cd26ac3459be8f79c4 Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 16:51:17 +0300 Subject: [PATCH 08/15] Add a type of x check --- src/bin_search.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/bin_search.py b/src/bin_search.py index 713abfc..15fd029 100644 --- a/src/bin_search.py +++ b/src/bin_search.py @@ -1,6 +1,9 @@ -def binSearch(xs: list[int], x: int): +def bin_search(xs: list[int], x: int): + + if type(x) != int: + raise "x is not an int" left, right = 0, len(xs) - 1 - while left < right: + while left <= right: mid = (left + right) // 2 if xs[mid] == x: return mid From 95fa80f2d102fc48945fc3f5f896bbf20f4f074a Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 16:54:16 +0300 Subject: [PATCH 09/15] Add tests for bin search --- test/test_bin_search.py | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 test/test_bin_search.py diff --git a/test/test_bin_search.py b/test/test_bin_search.py new file mode 100644 index 0000000..96362d1 --- /dev/null +++ b/test/test_bin_search.py @@ -0,0 +1,21 @@ +from src.bin_search import binSearch + + +def test_middle(): + assert binSearch([1, 2, 3, 4, 5], 4) == 3 + + +def test_start(): + assert binSearch([1, 2, 3, 4], 2) == 1 + + +def test_not_in_list(): + assert binSearch([1, 2, 3, 4], 5) == -1 + + +def test_binary_lenght_middle_right(): + assert binSearch([1, 2, 3, 4, 5, 6, 7, 8], 5) == 4 + + +def test_binary_lenght_middle_left(): + assert binSearch([1, 2, 3, 4, 5, 6, 7, 8], 4) == 3 From 2f24e02891c2304d7389766dacd7d2b4647a71b9 Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 16:57:52 +0300 Subject: [PATCH 10/15] Add a style-bug fixes --- src/bin_search.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/bin_search.py b/src/bin_search.py index 15fd029..a75c11e 100644 --- a/src/bin_search.py +++ b/src/bin_search.py @@ -1,5 +1,4 @@ def bin_search(xs: list[int], x: int): - if type(x) != int: raise "x is not an int" left, right = 0, len(xs) - 1 From 71c2bb14655fac6c102bb80150388d22d486645c Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 16:58:21 +0300 Subject: [PATCH 11/15] Add a style-bug fixes --- src/checksum.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/checksum.py b/src/checksum.py index 0502252..a9ea725 100644 --- a/src/checksum.py +++ b/src/checksum.py @@ -1,7 +1,9 @@ -def modulo11Checksum(ISBNNumber: str): +def modulo11checksum(ISBNNumber: str): digits = [int(char) for char in ISBNNumber if char.isdigit()] - assert (len(digits) == 9 and ISBNNumber[-1] == "X") or len(digits) == 10, "Invalid lenght" + assert (len(digits) == 9 and ISBNNumber[-1] == "X") or len(digits) == 10, ( + "Invalid lenght" + ) if ISBNNumber[-1] == "X": digits += 1 @@ -18,16 +20,17 @@ def modulo11Checksum(ISBNNumber: str): checksum = total + checkDigit return checksum % 11 == 0 + if __name__ == "__main__": while True: ISBN = input("Enter ISBN: ") if ISBN == "-1": break try: - result = modulo11Checksum(ISBN) + result = modulo11checksum(ISBN) if result: print("Correct") else: print("Incorrect") except Exception as e: - print(f"{type(e).__name__}: {e}") \ No newline at end of file + print(f"{type(e).__name__}: {e}") From 19ac4bf5d7d8a107fc6395a478a3e08ff0fc763f Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 16:59:05 +0300 Subject: [PATCH 12/15] Add a style-bug fixes --- test/test_checksum.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/test/test_checksum.py b/test/test_checksum.py index 962c30f..d495f69 100644 --- a/test/test_checksum.py +++ b/test/test_checksum.py @@ -1,21 +1,21 @@ -from src.checksum import modulo11Checksum +from src.checksum import modulo11checksum def test_good(): - assert modulo11Checksum("0-306-40615-2") - assert modulo11Checksum("0-306-40615-X") + assert modulo11checksum("0-306-40615-2") + assert modulo11checksum("0-306-40615-X") def test_bad(): - assert not modulo11Checksum("2-266-11156-3") + assert not modulo11checksum("2-266-11156-3") def test_invalid_isbn10(): - assert not modulo11Checksum("1234567890") + assert not modulo11checksum("1234567890") def test_edge_cases(): - assert not modulo11Checksum("123") - assert not modulo11Checksum("12341222223344455") - assert not modulo11Checksum("X-305-21345-2") - assert not modulo11Checksum("3-305-21345-A") \ No newline at end of file + assert not modulo11checksum("123") + assert not modulo11checksum("12341222223344455") + assert not modulo11checksum("X-305-21345-2") + assert not modulo11checksum("3-305-21345-A") From 1d0ea102be5583b26885b26a7fd90764192f2882 Mon Sep 17 00:00:00 2001 From: Vladimir Kirichenko Date: Mon, 8 Dec 2025 20:33:26 +0300 Subject: [PATCH 13/15] Changed python version --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index d09842c..5908b8f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -12,7 +12,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v5 with: - python-version: "3.13" + python-version: "3.12" - name: Install dependencies run: | From 24bb49d1e168b61255cb32a426caeffe299b4d26 Mon Sep 17 00:00:00 2001 From: VladimirKirichenko11 Date: Mon, 8 Dec 2025 20:43:40 +0300 Subject: [PATCH 14/15] Add .gitignore --- .gitignore | 207 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 207 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..b7faf40 --- /dev/null +++ b/.gitignore @@ -0,0 +1,207 @@ +# Byte-compiled / optimized / DLL files +__pycache__/ +*.py[codz] +*$py.class + +# C extensions +*.so + +# Distribution / packaging +.Python +build/ +develop-eggs/ +dist/ +downloads/ +eggs/ +.eggs/ +lib/ +lib64/ +parts/ +sdist/ +var/ +wheels/ +share/python-wheels/ +*.egg-info/ +.installed.cfg +*.egg +MANIFEST + +# PyInstaller +# Usually these files are written by a python script from a template +# before PyInstaller builds the exe, so as to inject date/other infos into it. +*.manifest +*.spec + +# Installer logs +pip-log.txt +pip-delete-this-directory.txt + +# Unit test / coverage reports +htmlcov/ +.tox/ +.nox/ +.coverage +.coverage.* +.cache +nosetests.xml +coverage.xml +*.cover +*.py.cover +.hypothesis/ +.pytest_cache/ +cover/ + +# Translations +*.mo +*.pot + +# Django stuff: +*.log +local_settings.py +db.sqlite3 +db.sqlite3-journal + +# Flask stuff: +instance/ +.webassets-cache + +# Scrapy stuff: +.scrapy + +# Sphinx documentation +docs/_build/ + +# PyBuilder +.pybuilder/ +target/ + +# Jupyter Notebook +.ipynb_checkpoints + +# IPython +profile_default/ +ipython_config.py + +# pyenv +# For a library or package, you might want to ignore these files since the code is +# intended to run in multiple environments; otherwise, check them in: +# .python-version + +# pipenv +# According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control. +# However, in case of collaboration, if having platform-specific dependencies or dependencies +# having no cross-platform support, pipenv may install dependencies that don't work, or not +# install all needed dependencies. +#Pipfile.lock + +# UV +# Similar to Pipfile.lock, it is generally recommended to include uv.lock in version control. +# This is especially recommended for binary packages to ensure reproducibility, and is more +# commonly ignored for libraries. +#uv.lock + +# poetry +# Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control. +# This is especially recommended for binary packages to ensure reproducibility, and is more +# commonly ignored for libraries. +# https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control +#poetry.lock +#poetry.toml + +# pdm +# Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control. +# pdm recommends including project-wide configuration in pdm.toml, but excluding .pdm-python. +# https://pdm-project.org/en/latest/usage/project/#working-with-version-control +#pdm.lock +#pdm.toml +.pdm-python +.pdm-build/ + +# pixi +# Similar to Pipfile.lock, it is generally recommended to include pixi.lock in version control. +#pixi.lock +# Pixi creates a virtual environment in the .pixi directory, just like venv module creates one +# in the .venv directory. It is recommended not to include this directory in version control. +.pixi + +# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm +__pypackages__/ + +# Celery stuff +celerybeat-schedule +celerybeat.pid + +# SageMath parsed files +*.sage.py + +# Environments +.env +.envrc +.venv +env/ +venv/ +ENV/ +env.bak/ +venv.bak/ + +# Spyder project settings +.spyderproject +.spyproject + +# Rope project settings +.ropeproject + +# mkdocs documentation +/site + +# mypy +.mypy_cache/ +.dmypy.json +dmypy.json + +# Pyre type checker +.pyre/ + +# pytype static type analyzer +.pytype/ + +# Cython debug symbols +cython_debug/ + +# PyCharm +# JetBrains specific template is maintained in a separate JetBrains.gitignore that can +# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore +# and can be added to the global gitignore or merged into this file. For a more nuclear +# option (not recommended) you can uncomment the following to ignore the entire idea folder. +#.idea/ + +# Abstra +# Abstra is an AI-powered process automation framework. +# Ignore directories containing user credentials, local state, and settings. +# Learn more at https://abstra.io/docs +.abstra/ + +# Visual Studio Code +# Visual Studio Code specific template is maintained in a separate VisualStudioCode.gitignore +# that can be found at https://github.com/github/gitignore/blob/main/Global/VisualStudioCode.gitignore +# and can be added to the global gitignore or merged into this file. However, if you prefer, +# you could uncomment the following to ignore the entire vscode folder +# .vscode/ + +# Ruff stuff: +.ruff_cache/ + +# PyPI configuration file +.pypirc + +# Cursor +# Cursor is an AI-powered code editor. `.cursorignore` specifies files/directories to +# exclude from AI features like autocomplete and code analysis. Recommended for sensitive data +# refer to https://docs.cursor.com/context/ignore-files +.cursorignore +.cursorindexingignore + +# Marimo +marimo/_static/ +marimo/_lsp/ +__marimo__/ From 13b8ce48d201b592def94e1725d670585721a213 Mon Sep 17 00:00:00 2001 From: VladimirKirichenko11 Date: Mon, 8 Dec 2025 20:44:42 +0300 Subject: [PATCH 15/15] Add LICENSE --- LICENSE | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 LICENSE diff --git a/LICENSE b/LICENSE new file mode 100644 index 0000000..293f14c --- /dev/null +++ b/LICENSE @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2025 VladimirKirichenko11 + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE.