Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Werkzeug, Flask, and Python Versions for flask-restx 0.2.0 #37

Closed
j5awry opened this issue Feb 7, 2020 · 6 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@j5awry
Copy link
Contributor

j5awry commented Feb 7, 2020

Werkzeug 1.0 was released Feb 6th and removes py3.4 support.
Flask requires Werkzeug >= 0.15.0, so a default install from scratch will pull WZ 1.0
Flask has moved onto the 1.X series as of mid-2018 but we "allow" 0.8+

Address the large variance and forward motion of flask and werkzeug.

Flask >= 1.0.2 (1.0 and 1.0.1 had bugs. 1.0.2 stayed stable for ayear)
Werkzeug >= 1.0 (yes, forcing forward compatibility with 1.0 series)

remove py34

Related to #34 and #35

@j5awry j5awry added enhancement New feature or request good first issue Good for newcomers labels Feb 7, 2020
@ziirish
Copy link
Contributor

ziirish commented Feb 7, 2020

My plan would be to:

  1. merge Using GitHub Actions instead of Travis CI #18
  2. remove python 3.4 from the test-suite and address the above points
  3. rebase Remove deprecated werkzeug import #35
  4. merge Remove deprecated werkzeug import #35
  5. release v0.2.0

@ziirish
Copy link
Contributor

ziirish commented Feb 7, 2020

Also, we should address those points as soon as possible, since werkzeug 1.0 is now out and the damages are popping everywhere.

The next thing would be to address our dependency automation discussed in #29

@plowman
Copy link
Contributor

plowman commented Mar 5, 2020

Hey @ziirish what's the word on version 0.2.0? Is it just waiting on #63 still?

@ziirish
Copy link
Contributor

ziirish commented Mar 5, 2020 via email

@indy-independence
Copy link

No, I think we can go ahead with 0.2.0We'll setup dependabot for v1.0.0

When do you think 0.2.0 will be released? It sounds like it might be pretty soon and I'm considering if I should wait for it before doing a beta release with dependencies on flask-restx

@j5awry j5awry mentioned this issue Mar 16, 2020
@j5awry
Copy link
Contributor Author

j5awry commented Apr 5, 2020

This is addressed in the version 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants