Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django 5.0 (and python 3.12) #516

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

pfouque
Copy link
Contributor

@pfouque pfouque commented Oct 14, 2023

Proposed changes

Add official support for Django 5 (and Python 3.12)
Update test matrix based on Django's official supported versions

Types of changes

Please check the type of change your PR introduces:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f8eafed) 94.12% compared to head (08ef33f) 94.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #516   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files          39       39           
  Lines        1140     1140           
  Branches      133      133           
=======================================
  Hits         1073     1073           
  Misses         43       43           
  Partials       24       24           
Flag Coverage Δ
unittests 94.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfouque pfouque changed the title Support Django 5.0 Support Django 5.0 (and python 3.12) Oct 14, 2023
@nijel nijel merged commit 93f5127 into python-social-auth:master Oct 17, 2023
10 checks passed
@nijel
Copy link
Member

nijel commented Oct 17, 2023

Merged, thanks for your contribution!

@nijel nijel self-assigned this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants