You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the SAML backend supplies a fullname, my Django user should have first_name and last_name set: if fullname is set but not first_name/last_name, PSA should (optionally?) generate a first_name and last_name automatically (my inclination is something like first_name, _space, last_name = fullname.rpartition(' ')). If there are systems (that is, non-Django web frameworks) that want a fullname, it should do the opposite transformation when fullname is missing.
Actual behaviour
My Django user has neither first_name nor last_name.
What are the steps to reproduce this issue?
Input clear steps to reproduce the issue for a maintainer.
Use social_django
Configure the SAML backend to return a fullname, but not a first_name or last_name
Log in using SAML
Observe that the Django user created doesn't have a first_name/last_name set
Any logs, error output, etc?
N/A
Any other comments?
Unfortunate I don't understand how data flows through PSA well enough to supply a patch.
I suspect that this ideally wants to be configurable (on/off and perhaps a custom fullname->first_name/last_name function) per-backend.
The text was updated successfully, but these errors were encountered:
dehnert
added a commit
to dehnert/social-core
that referenced
this issue
May 8, 2022
Expected behaviour
When the SAML backend supplies a
fullname
, my Django user should havefirst_name
andlast_name
set: iffullname
is set but notfirst_name
/last_name
, PSA should (optionally?) generate afirst_name
andlast_name
automatically (my inclination is something likefirst_name, _space, last_name = fullname.rpartition(' ')
). If there are systems (that is, non-Django web frameworks) that want afullname
, it should do the opposite transformation whenfullname
is missing.Actual behaviour
My Django user has neither first_name nor last_name.
What are the steps to reproduce this issue?
Input clear steps to reproduce the issue for a maintainer.
Any logs, error output, etc?
N/A
Any other comments?
Unfortunate I don't understand how data flows through PSA well enough to supply a patch.
I suspect that this ideally wants to be configurable (on/off and perhaps a custom
fullname
->first_name
/last_name
function) per-backend.The text was updated successfully, but these errors were encountered: