Skip 'at_hash' claim validation when missing #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #852 +/- ##
=======================================
Coverage 77.20% 77.20%
=======================================
Files 339 339
Lines 10340 10340
Branches 696 696
=======================================
Hits 7983 7983
Misses 2200 2200
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
browniebroke
commented
Nov 7, 2023
| if claims.get("at_hash") != self.calc_at_hash(access_token, key["alg"]): | ||
| if "at_hash" in claims and claims["at_hash"] != self.calc_at_hash( | ||
| access_token, key["alg"] | ||
| ): | ||
| raise AuthTokenError(self, "Invalid access token") |
There was a problem hiding this comment.
As far as I can tell, this isn't covered by the tests currently.
There was a problem hiding this comment.
Apparently, there is no test where at_hash claim would be missing, so this behavior is not tested (otherwise we would see a test failure earlier).
|
Merged, thanks for your contribution! |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix validation error when the
at_hashclaim is absent.Types of changes
Please check the type of change your PR introduces:
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
Other information
Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.