Skip to content

Conversation

@AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Nov 13, 2025

This is derived from Hugo's #4704; see that PR for context.

This PR is an attempt to implement @sethmlarson's suggestion -- attempting to do this via review comments wasn't really going to work!

The ICS generation is now much simpler with no dependencies, simply outputting the required strings. I've also limited past events to 7 years to keep the file size smaller (for ~18months of pre-releases and a five-year lifespan). Realistically this could be much shorter, but I've been conservative.

A


📚 Documentation preview 📚: https://pep-previews--4705.org.readthedocs.build/release-schedule.ics

@AA-Turner AA-Turner requested a review from a team as a code owner November 13, 2025 20:03
@AA-Turner AA-Turner added the infra Core infrastructure for building and rendering PEPs label Nov 13, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@AA-Turner AA-Turner requested a review from hugovk November 17, 2025 21:38
AA-Turner and others added 5 commits November 22, 2025 13:26
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Comment on lines 74 to 79
# Disabled: no support for comments as at 2025-11-27.
# - repo: https://github.com/tox-dev/tox-ini-fmt
# rev: 1.4.1
# hooks:
# - id: tox-ini-fmt
# name: "Format tox.ini"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @hugovk per #4715 (comment). The other option is to keep tox-ini-fmt but remove the comments entirely. What do you prefer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep tox-ini-fmt and remove the comments, the comments are quite self-explanatory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I encounter the need for autoformatting tox.ini !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes maintenance much easier when you can compare across repos and all the similar stuff is, well, similar. Like sections and keys in the same order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Core infrastructure for building and rendering PEPs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants