Skip to content

Commit 550ff69

Browse files
committed
added FInal markings and stubtest_allowlist comments
1 parent a8ea4a1 commit 550ff69

File tree

4 files changed

+40
-35
lines changed

4 files changed

+40
-35
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
1+
# Tests
12
ephem.tests.*
3+
4+
# Leaked loop variables
25
ephem.stars.k
36
ephem.stars.v
7+
8+
# Runtime signature has *args/**kwargs that raise TypeError; stub signature is correct
49
ephem._libastro.Observer.__init__
510
ephem.FixedBody.__init__
611
ephem._libastro.FixedBody.__init__

stubs/ephem/ephem/__init__.pyi

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -5,31 +5,31 @@ from typing_extensions import Self
55

66
from . import _libastro
77

8-
__version__: str
8+
__version__: Final[str]
99

1010
# Mathematical constants
11-
tau: float
12-
twopi: float
13-
halfpi: float
14-
quarterpi: float
15-
eighthpi: float
16-
degree: float
17-
arcminute: float
18-
arcsecond: float
19-
half_arcsecond: float
20-
tiny: float
11+
tau: Final[float]
12+
twopi: Final[float]
13+
halfpi: Final[float]
14+
quarterpi: Final[float]
15+
eighthpi: Final[float]
16+
degree: Final[float]
17+
arcminute: Final[float]
18+
arcsecond: Final[float]
19+
half_arcsecond: Final[float]
20+
tiny: Final[float]
2121

2222
# Physical constants
23-
c: float
24-
meters_per_au: float
25-
earth_radius: float
26-
moon_radius: float
27-
sun_radius: float
23+
c: Final[float]
24+
meters_per_au: Final[float]
25+
earth_radius: Final[float]
26+
moon_radius: Final[float]
27+
sun_radius: Final[float]
2828

2929
# Epoch constants
30-
B1900: float
31-
B1950: float
32-
J2000: float
30+
B1900: Final[float]
31+
B1950: Final[float]
32+
J2000: Final[float]
3333

3434
# Type imports from _libastro
3535
Angle = _libastro.Angle
@@ -38,13 +38,13 @@ hours = _libastro.hours
3838
Date = _libastro.Date
3939

4040
# Time constants
41-
hour: float
42-
minute: float
43-
second: float
41+
hour: Final[float]
42+
minute: Final[float]
43+
second: Final[float]
4444

4545
# Precision constants
46-
default_newton_precision: float
47-
rise_set_iterations: tuple[int, int, int, int, int, int, int]
46+
default_newton_precision: Final[float]
47+
rise_set_iterations: Final[tuple[int, int, int, int, int, int, int]]
4848

4949
# Function imports from _libastro
5050
delta_t = _libastro.delta_t

stubs/ephem/ephem/_libastro.pyi

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from _typeshed import Unused
22
from datetime import datetime as _datetime
3-
from typing import NoReturn, Protocol, TypedDict, overload, type_check_only
3+
from typing import Final, NoReturn, Protocol, TypedDict, overload, type_check_only
44
from typing_extensions import Self, TypeAlias, deprecated, disjoint_base
55

66
_DateInitType: TypeAlias = (
@@ -52,12 +52,12 @@ class _AngleDescriptorDegreesRadians:
5252
@overload
5353
def __set__(self, obj: object, value: float | str) -> None: ...
5454

55-
J2000: float
56-
MJD0: float
57-
earth_radius: float
58-
meters_per_au: float
59-
moon_radius: float
60-
sun_radius: float
55+
J2000: Final[float]
56+
MJD0: Final[float]
57+
earth_radius: Final[float]
58+
meters_per_au: Final[float]
59+
moon_radius: Final[float]
60+
sun_radius: Final[float]
6161

6262
@disjoint_base
6363
class Angle(float): # type: ignore[type-var]

stubs/ephem/ephem/stars.pyi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
from typing import overload
1+
from typing import Final, overload
22

33
from . import FixedBody, Observer
44
from ._libastro import _DateInitType
55

6-
db: str
6+
db: Final[str]
77
stars: dict[str, FixedBody]
88

99
@overload
1010
def star(name: str, observer: Observer, /) -> FixedBody: ...
1111
@overload
1212
def star(name: str, when: _DateInitType = ..., epoch: _DateInitType = ...) -> FixedBody: ...
1313

14-
STAR_NUMBER_NAME: dict[int, str]
15-
STAR_NAME_NUMBER: dict[str, int]
14+
STAR_NUMBER_NAME: Final[dict[int, str]]
15+
STAR_NAME_NUMBER: Final[dict[str, int]]

0 commit comments

Comments
 (0)