From 407c3c43624a58d0530777e4d3513a380fba66bb Mon Sep 17 00:00:00 2001 From: Darren Eberly Date: Thu, 22 Aug 2024 23:35:25 -0400 Subject: [PATCH] Cleanup deprecation warnings for etree.Element comparisons in TMX parser --- pytiled_parser/parsers/tmx/tiled_map.py | 2 +- pytiled_parser/parsers/tmx/tiled_object.py | 2 +- pytiled_parser/parsers/tmx/wang_set.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pytiled_parser/parsers/tmx/tiled_map.py b/pytiled_parser/parsers/tmx/tiled_map.py index 3a582857..a7af55a6 100644 --- a/pytiled_parser/parsers/tmx/tiled_map.py +++ b/pytiled_parser/parsers/tmx/tiled_map.py @@ -133,7 +133,7 @@ def parse(file: Path) -> TiledMap: map_.hex_side_length = int(raw_map.attrib["hexsidelength"]) properties_element = raw_map.find("./properties") - if properties_element: + if properties_element is not None: map_.properties = parse_properties(properties_element) if raw_map.attrib.get("staggeraxis") is not None: diff --git a/pytiled_parser/parsers/tmx/tiled_object.py b/pytiled_parser/parsers/tmx/tiled_object.py index 820f37ad..498685ee 100644 --- a/pytiled_parser/parsers/tmx/tiled_object.py +++ b/pytiled_parser/parsers/tmx/tiled_object.py @@ -55,7 +55,7 @@ def _parse_common(raw_object: etree.Element) -> TiledObject: common.class_ = raw_object.attrib["class"] properties_element = raw_object.find("./properties") - if properties_element: + if properties_element is not None: common.properties = parse_properties(properties_element) return common diff --git a/pytiled_parser/parsers/tmx/wang_set.py b/pytiled_parser/parsers/tmx/wang_set.py index 0789cb10..34013117 100644 --- a/pytiled_parser/parsers/tmx/wang_set.py +++ b/pytiled_parser/parsers/tmx/wang_set.py @@ -38,7 +38,7 @@ def _parse_wang_color(raw_wang_color: etree.Element) -> WangColor: wang_color.class_ = raw_wang_color.attrib["class"] properties = raw_wang_color.find("./properties") - if properties: + if properties is not None: wang_color.properties = parse_properties(properties) return wang_color @@ -74,7 +74,7 @@ def parse(raw_wangset: etree.Element) -> WangSet: wangset.class_ = raw_wangset.attrib["class"] properties = raw_wangset.find("./properties") - if properties: + if properties is not None: wangset.properties = parse_properties(properties) return wangset