Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock no longer locks #329

Closed
dchatel opened this issue Aug 31, 2024 · 8 comments
Closed

Lock no longer locks #329

dchatel opened this issue Aug 31, 2024 · 8 comments

Comments

@dchatel
Copy link

dchatel commented Aug 31, 2024

Pretty much self explanatory. Lock no longer locks, it only adds the lock icon but does nothing else.

[DONE] Security scan
## ComfyUI-Manager: installing dependencies done.
** ComfyUI startup time: 2024-08-31 07:42:46.184949
** Platform: Windows
** Python version: 3.11.9 | packaged by Anaconda, Inc. | (main, Apr 19 2024, 16:40:41) [MSC v.1916 64 bit (AMD64)]
** Python executable: C:\Users\dchat\miniconda3\envs\comfy\python.exe
** ComfyUI Path: G:\ai\ComfyUI
** Log path: G:\ai\ComfyUI\comfyui.log

Prestartup times for custom nodes:
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\rgthree-comfy
   1.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-Manager

Total VRAM 24564 MB, total RAM 32581 MB
pytorch version: 2.4.0+cu121
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090 : cudaMallocAsync
Using pytorch cross attention
[Prompt Server] web root: G:\ai\ComfyUI\web_custom_versions\Comfy-Org_ComfyUI_frontend\1.2.41
Adding extra search path checkpoints g:/ai/models/stable-diffusion/
Adding extra search path controlnet g:/ai/models/controlnet/
Adding extra search path embeddings g:/ai/models/embeddings/
Adding extra search path loras g:/ai/models/lora/
Adding extra search path upscale_models g:/ai/models/upscale-models/
Adding extra search path vae g:/ai/models/vae/
C:\Users\dchat\miniconda3\envs\comfy\Lib\site-packages\kornia\feature\lightglue.py:44: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead.
  @torch.cuda.amp.custom_fwd(cast_inputs=torch.float32)
[Crystools INFO] Crystools version: 1.16.6
[Crystools INFO] CPU: 12th Gen Intel(R) Core(TM) i7-12700KF - Arch: Arch unknown - OS: Windows 10
[Crystools INFO] Pynvml (Nvidia) initialized.
[Crystools INFO] GPU/s:
[Crystools INFO] 0) NVIDIA GeForce RTX 4090
[Crystools INFO] NVIDIA Driver: 560.94
### Loading: ComfyUI-Impact-Pack (V7.4)
### Loading: ComfyUI-Impact-Pack (Subpack: V0.6)
[Impact Pack] Wildcards loading done.
### Loading: ComfyUI-Inspire-Pack (V1.0)
Total VRAM 24564 MB, total RAM 32581 MB
pytorch version: 2.4.0+cu121
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090 : cudaMallocAsync
### Loading: ComfyUI-Manager (V2.50.3)
### ComfyUI Revision: 2635 [c90459eb] | Released on '2024-08-30'
[comfyui_controlnet_aux] | INFO -> Using ckpts path: G:\ai\ComfyUI\custom_nodes\comfyui_controlnet_aux\ckpts
[comfyui_controlnet_aux] | INFO -> Using symlinks: False
[comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']
DWPose: Onnxruntime with acceleration providers detected
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
FizzleDorf Custom Nodes: Loaded

[rgthree] Loaded 42 magnificent nodes.


Import times for custom nodes:
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\websocket_image_save.py
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\srl-nodes
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\comfyui_lora_tag_loader
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\cg-use-everywhere
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUi_NNLatentUpscale
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\Euler-Smea-Dyn-Sampler
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-ELLA
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI_IPAdapter_plus
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI_essentials
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-Frame-Interpolation
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-GGUF
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\x-flux-comfyui
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\rgthree-comfy
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\comfyui_davcha
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-KJNodes
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-Image-Inpainting
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\comfyui_controlnet_aux
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack
   0.0 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-DynamiCrafterWrapper
   0.1 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-Crystools
   0.1 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite
   0.2 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI_FizzNodes
   0.3 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-Manager
   0.3 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-eesahesNodes
   0.4 seconds: G:\ai\ComfyUI\custom_nodes\comfyui_facetools
   0.6 seconds: G:\ai\ComfyUI\custom_nodes\ComfyUI-Impact-Pack

Setting output directory to: G:\ai\outputs
Starting server

To see the GUI go to: http://127.0.0.1:8188```
@Kuroha33
Copy link

Kuroha33 commented Sep 1, 2024

the same thing happened to me, any solution?

@LinuxWhiz
Copy link

LinuxWhiz commented Sep 1, 2024 via email

@Skuuurt
Copy link

Skuuurt commented Sep 1, 2024

I have the same issue

@925-Studio
Copy link

925-Studio commented Sep 3, 2024

Same here. Group lock still works but node lock doesn't anymore. Latest ComfyUI with new UI.

@gardobeson
Copy link

Same. Looks like the new comfy update broke this functionality somehow. I'm going to look into it on my end a bit. Maybe I can figure it out.

@gardobeson
Copy link

I was unable to figure it out. If I had to guess it's got something to do with nodeType because I'm a noob and VSCode is giving me the big red on that.

@pythongosssss
Copy link
Owner

This is now supported as a core feature in the latest version of ComfyUI frontend as "Pin", or by selecting a node and pressing P.
image

Comfy-Org/ComfyUI_frontend#736

@dchatel
Copy link
Author

dchatel commented Sep 6, 2024

It's a bit different. Your lock feature had the possibility to collapse/uncollapse the locked node. Pin doesn't allow this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants