-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CUTLASS-based row-wise scaled sparse FP8 kernel #1671
base: main
Are you sure you want to change the base?
Add CUTLASS-based row-wise scaled sparse FP8 kernel #1671
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1671
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit d1d96f7 with merge base d00ee41 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The kernel is ready and passes smoke test. Remaining tasks:
|
5bbcc49
to
6d34b7e
Compare
bd7288a
to
f11fae4
Compare
bf65c83
to
c0368e3
Compare
Testing this PR revealed that the sparse compressor in CUTLASS is not treating -0.0 values as zeros. The upstream fix is proposed here. |
c0368e3
to
4c63c65
Compare
05ed2d4
to
6fb6165
Compare
This PR is ready for review. It contains:
I'll address the performance tuning (through CUTLASS run-time config selection), that is mentioned as a remaining task above, in a separate PR. @drisspg The @jcaip If you think there is a need, we may discuss eventually exposing mentioned new operators through @gau-nernst With this PR, it's possible to try CUTLASS-based W4A4 operator from the Llama generator - run with |
ad04e4b
to
a7197f7
Compare
a7197f7
to
d1d96f7
Compare
No description provided.