We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch static type checker to mypy and include mypy compatible type stubs (PEP 561 compliant) by adding a py.typed file at the root of torchx module (see https://mypy.readthedocs.io/en/stable/installed_packages.html#creating-pep-561-compatible-packages).
py.typed
torchx
TorchX currently uses pyre which works well for Meta's internal builds but is sub-optimal in OSS for several reasons:
Switching over to mypy would involve a few changes:
mypy.ini
dev-requirements.txt
torchx.*
N/A - mypy is itself an alternative to pyre.
N/A
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Description
Switch static type checker to mypy and include mypy compatible type stubs (PEP 561 compliant) by adding a
py.typed
file at the root oftorchx
module (see https://mypy.readthedocs.io/en/stable/installed_packages.html#creating-pep-561-compatible-packages).Motivation/Background
TorchX currently uses pyre which works well for Meta's internal builds but is sub-optimal in OSS for several reasons:
Detailed Proposal
Switching over to mypy would involve a few changes:
mypy.ini
file and updatingdev-requirements.txt
with a dependency to mypy (instead of pyre)torchx.*
mypy compliant since pyre and mypy rules are slightly differentAlternatives
N/A - mypy is itself an alternative to pyre.
Additional context/links
N/A
The text was updated successfully, but these errors were encountered: