-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in forks break non HTML pages #424
Comments
For the calendar particularly this is being handled in naucse.python.cz/naucse/views.py Lines 825 to 834 in 71cbde9
We need to return something that has correct content type. |
It's actually in the naucse.python.cz/naucse/views.py Lines 901 to 910 in 71cbde9
To handle this in a static site we'd need an |
Right. Well, we can set the content type as a dirty workaround. The static site will then download an ics file with HTML content which isn't great, but at least it would build. Later, we can change the error to plaintext maybe. |
There's a power outage, so I'm on battery and cell data, so don't expect an actual fix/workaround from me any time soon (as it involves pulling docker images etc.). |
ACK, I'll do the workaround. |
Current implementation breaks the entire build if this happens, as do any errors. See #494 for a high-level plan |
When there is an error on a non-HTML page (such as ics), there is a HTML page rendered. That breaks FrozenFlask (expecting text/calendar by the filename, gets text/html).
No idea how we are supposed to handle this, but the current implementation breaks the entire build if this happens.
See #423 (comment) for context.
The text was updated successfully, but these errors were encountered: