Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxPacketSize from PR #417 might impact performance #420

Open
sessl3r opened this issue Mar 14, 2024 · 0 comments
Open

MaxPacketSize from PR #417 might impact performance #420

sessl3r opened this issue Mar 14, 2024 · 0 comments

Comments

@sessl3r
Copy link
Contributor

sessl3r commented Mar 14, 2024

PR #417 has fixed a issue with Rigol scopes and likely others by using the reported MaxPacketSize of the USB endpoints.
A similar PR was merged into usbtmc linux driver.

In the discussion over there it came up, that some Agilent scopes report a smaller MaxPacketSize then they can handle in reality and therefore this change decreased performance. I can not validate this and think it is bad practice to use those bigger packet sizes.

I completely dislike the way this was now solved in the usbtmc driver (default is 4k, user can overwrite to use the reported value). However I agree that if users have performance issues a overwrite option could be introduced for such quirks.

This is not a current issue - just a reminder to not loose this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant