-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify getting atomic scattering parameters #120
Comments
Got no time for this unfortunately, hopefully someone else can pick this up. |
@hakonanes any thoughts on this? I was going to add in ionic scattering parameters (I guess why not right) and figured I should go all the way if I'm doing that. |
I was thinking that we set up each table in the form of a nested dict with:
|
This would obviously be an improvement to the API, but unless somebody needs it urgently I think we should deprioritise it (at least until #201 and it's support PR are in). Obviously if @CSSFrancis is using ionic scattering day-to-day we should pick it back up. |
@pc494 I'm not using them and I should probably focus my efforts a bit more so I'll leave this at I'll come back to it unless someone else needs it. Releasing a 1.0.0 version of pyxem is already looking pretty daunting but we see getting there slowly. |
Is your feature request related to a problem? Please describe.
There are now multiple parametrizations of atomic scattering parameters in the code:
Describe the solution you'd like
diffsims.structure_factor
module, which makes most sense?Atom.element
(like "H", "Ni", etc.), a string or an integer, and which parametrization of the above to use. The parameters are returned.The text was updated successfully, but these errors were encountered: