Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation bug #1

Open
sama55 opened this issue Mar 26, 2014 · 3 comments
Open

Navigation bug #1

sama55 opened this issue Mar 26, 2014 · 3 comments

Comments

@sama55
Copy link

sama55 commented Mar 26, 2014

Thank you nice plugin. I found 2 issue.

  1. qa-webmaster-layer.php (L50)

    $this->content['navigation']['main']['webmaster']['selected'] = true;
    // $this->content['navigation']['main']['selected'] = true; // << Unnecessary code

  2. CSS of tab is not applied

@TohidN
Copy link
Member

TohidN commented Mar 30, 2014

thanks for reporting these issues.

  1. you are right, I removed it.
  2. I just checked this plugin with 2 other themes, but it was styled correctly. can you please tell me where did you notice this issue?

@sama55
Copy link
Author

sama55 commented Mar 30, 2014

I thank for your correspondence.
About issue 2.
There was not surely problem on the current theme. My theme is none standard HTML5. And, jquery script is linked in the last of body. Therefore, it was caused by the fact that your inline script became error. Q2A will shift to HTML5 in V1.7. In addition, script may be linked in the last of body at that time.

Example code which works on my HTML5 theme:

function head_script(){
    qa_html_theme_base::head_script();
    global $qa_request;
    if ( ($qa_request == 'webmaster') && (qa_get_logged_in_level()>=QA_USER_LEVEL_ADMIN) ) {
        $this->output('<script type="text/javascript" src="'. qa_opt('site_url') . $this->plugin_url .'include/easyResponsiveTabs.js"></script>');
        $this->output(
            '<script type="text/javascript">',
            '$("#verticalTab").easyResponsiveTabs({',
            '   type: "vertical",',      
            '   width: "auto",',
            '   fit: true',
            '});',
            '</script>'
        );
    }
}   
function body_footer(){
    global $qa_request;
    /*
    if ( ($qa_request == 'webmaster') && (qa_get_logged_in_level()>=QA_USER_LEVEL_ADMIN) )
        $this->output(
            '<script type="text/javascript">',
            '$("#verticalTab").easyResponsiveTabs({',
            '   type: "vertical",',      
            '   width: "auto",',
            '   fit: true',
            '});',
            '</script>'
        );
    */
    qa_html_theme_base::body_footer();
}

Thanks.

@TohidN
Copy link
Member

TohidN commented Mar 31, 2014

ok, in next version I'll add a js file instead of inline code. I'm planning to add even more features to this plugin so I'll do them all at the same time.
thanks for contributing.

TohidN added a commit that referenced this issue Feb 21, 2015
TohidN added a commit that referenced this issue Feb 21, 2015
This reverts commit 26a599f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants