Feature: Fallback Suffixing

[llmII]

With the merging of #69 and #80 I think now it might be a good time to look into no suffixing by default and adding a few features.

• Don't suffix by default - add an option force_suffix and if that's true fallback to current behavior.
• Detect if we encounter a forced nick change (Chanserv Enforcement for instance) with an "NICK" handler on IRCConnection that looks for the "looks like a forced nick" indicator described in a setting unwanted_nick_change_prefix. The said setting would default to "Guest". If such is detected issue a nick change to what the puppet's nick should be with the now mandatorily filled in suffix setting.

So all in all we would have 4 settings dealing with suffixing and nicks:

1. suffix
2. separator
3. force_suffix
4. unwanted_nick_change_prefix

Discussion as to if this is a good idea or not or if it is a good idea, perhaps a better way of going about implementation than priorly described, would be helpful in determining if this would be worth putting effort into.

[qaisjp]

Don't suffix by default

Some people (myself included) use both IRC and Discord, and this would prevent those people from doing that (as their IRC nick would be taken by the bridge).

But I'm generally happy to improve support for no suffixing.

Detect if we encounter a forced nick change (Chanserv Enforcement for instance) with an "NICK" handler on IRCConnection

Oh, I didn't know there was an easy way to encounter a forced nick change. Yes, we could do this. And if the user is already suffixed, fall back to the extended suffix (i.e. the one with discriminator).

looks for the "looks like a forced nick" indicator described in a setting unwanted_nick_change_prefix. The said setting would default to "Guest". If such is detected issue a nick change to what the puppet's nick should be with the now mandatorily filled in suffix setting.

Do we need this if we can detect an enforced nick change? I was thinking we could go for the fallback if a nick change is detected altogether.

Thoughts?

[llmII]

Don't suffix by default

Some people (myself included) use both IRC and Discord, and this would prevent those people from doing that (as their IRC nick would be taken by the bridge).

Didn't think of that, would lead to /ns GHOST being used a lot more probably.

But I'm generally happy to improve support for no suffixing.

Detect if we encounter a forced nick change (Chanserv Enforcement for instance) with an "NICK" handler on IRCConnection

Oh, I didn't know there was an easy way to encounter a forced nick change. Yes, we could do this. And if the user is already suffixed, fall back to the extended suffix (i.e. the one with discriminator).

looks for the "looks like a forced nick" indicator described in a setting unwanted_nick_change_prefix. The said setting would default to "Guest". If such is detected issue a nick change to what the puppet's nick should be with the now mandatorily filled in suffix setting.

I'll try to look into figuring this one out, using /sanick on a test network should sufficiently simulate this.

Do we need this if we can detect an enforced nick change? I was thinking we could go for the fallback if a nick change is detected altogether.

Thoughts?

As far as I can tell, NickServ and alike do the equivalent of /sanick - keeping track of "did I issue a NICK" or not is a lot harder than checking for "Does my nick now match a bad pattern" since you just see the "NICK xyz zyx" regardless of if you sent the original "NICK" or not.

[qaisjp]

NICK xyz zyx

Oh nice, it includes the old nick! We could compare the old nick to the nick we most recently requested?