Skip to content

Commit f2097dc

Browse files
authored
Avoid redundant copy
PR #22035.
1 parent 166feb5 commit f2097dc

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

src/base/http/requestparser.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ bool RequestParser::parseStartLines(const QStringView data)
164164
if (line.at(0).isSpace() && !requestLines.isEmpty())
165165
{
166166
// continuation of previous line
167-
requestLines.last() += line.toString();
167+
requestLines.last() += line;
168168
}
169169
else
170170
{
@@ -225,9 +225,7 @@ bool RequestParser::parseRequestLine(const QString &line)
225225
const QByteArrayView valueComponent = param.mid(eqCharPos + 1);
226226
const QString paramName = QString::fromUtf8(
227227
QByteArray::fromPercentEncoding(asQByteArray(nameComponent)).replace('+', ' '));
228-
const QByteArray paramValue = valueComponent.isNull()
229-
? QByteArray("")
230-
: QByteArray::fromPercentEncoding(asQByteArray(valueComponent)).replace('+', ' ');
228+
const QByteArray paramValue = QByteArray::fromPercentEncoding(asQByteArray(valueComponent)).replace('+', ' ');
231229

232230
m_request.query[paramName] = paramValue;
233231
}
@@ -337,7 +335,7 @@ bool RequestParser::parseFormData(const QByteArrayView data)
337335
}
338336
else
339337
{
340-
if (!parseHeaderLine(line.toString(), headersMap))
338+
if (!parseHeaderLine(line, headersMap))
341339
return false;
342340
}
343341
}
@@ -348,7 +346,8 @@ bool RequestParser::parseFormData(const QByteArrayView data)
348346

349347
if (headersMap.contains(filename))
350348
{
351-
m_request.files.append({headersMap[filename], headersMap[HEADER_CONTENT_TYPE], payload.toByteArray()});
349+
m_request.files.append({.filename = headersMap[filename], .type = headersMap[HEADER_CONTENT_TYPE]
350+
, .data = payload.toByteArray()});
352351
}
353352
else if (headersMap.contains(name))
354353
{

0 commit comments

Comments
 (0)