From 4b87a9798a8fdc07a1b45f0117fb0dcd45d51c9e Mon Sep 17 00:00:00 2001 From: Geoffrey Wu Date: Wed, 5 Feb 2025 02:49:41 -0500 Subject: [PATCH] fix premature category loading --- client/multiplayer/room.jsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/client/multiplayer/room.jsx b/client/multiplayer/room.jsx index 8e7a638f..62f5e340 100644 --- a/client/multiplayer/room.jsx +++ b/client/multiplayer/room.jsx @@ -298,8 +298,7 @@ async function connectionAcknowledgedQuery ({ document.getElementById('toggle-standard-only').checked = standardOnly; - categoryManager.import({ categories, subcategories, alternateSubcategories, percentView, categoryPercents }); - categoryManager.loadCategoryModal(); + setCategories({ categories, subcategories, alternateSubcategories, percentView, categoryPercents }); $(document).ready(function () { $('#slider').slider('values', 0, minYear); @@ -595,6 +594,9 @@ function revealAnswer ({ answer, question }) { function setCategories ({ alternateSubcategories, categories, subcategories, percentView, categoryPercents, username }) { logEventConditionally(username, 'updated the categories'); categoryManager.import({ categories, subcategories, alternateSubcategories, percentView, categoryPercents }); + + if (!document.getElementById('category-modal')) { return; } + categoryManager.loadCategoryModal(); }