Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider PVF executor params #1691

Closed
Harrm opened this issue Jul 12, 2023 · 1 comment · Fixed by #2218
Closed

Consider PVF executor params #1691

Harrm opened this issue Jul 12, 2023 · 1 comment · Fixed by #2218
Assignees
@ErakhtinB
Labels
Parachains Runtime

Comments

@Harrm
Copy link
Contributor

Harrm commented Jul 12, 2023

https://spec.polkadot.network/chap-runtime-api#sect-rt-api-executor_params

We can fetch timeouts for pvf runtime calls execution and should probably honor them.
@Harrm Harrm self-assigned this Jul 12, 2023
@turuslan turuslan mentioned this issue Jul 19, 2023
Merged
@kamilsa
Copy link
Contributor

kamilsa commented Sep 2, 2024

Note from @turuslan :
We implemented MaxMemoryPages, StackLogicalMax (wasm instrumentation, stack limiter)

but StackNativeMax, PrecheckingMaxMemory
and PvfPrepTimeout, PvfExecTimeout
were not implemented

@kamilsa kamilsa assigned ErakhtinB and unassigned Harrm Sep 16, 2024
@ErakhtinB ErakhtinB linked a pull request Sep 19, 2024 that will close this issue
1691 consider pvf executor params #2218
Merged
@ErakhtinB ErakhtinB mentioned this issue Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErakhtinB ErakhtinB

Labels
Parachains Runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1691 consider pvf executor params qdrvm/kagome
3 participants
@kamilsa @Harrm @ErakhtinB