diff --git a/NEWS.md b/NEWS.md index f5a3d4d..af99f6e 100644 --- a/NEWS.md +++ b/NEWS.md @@ -6,6 +6,7 @@ - All layers now support geometry vectors which {wk} can read (#104) - Feature editor accepts geometry vectors which {wk} can read (#105) - Use {yyjsonr} for faster serialisation (#110) +- Fix quantile scales (#108) # rdeck 0.5.2 diff --git a/R/scales.R b/R/scales.R index 229596f..81197c6 100644 --- a/R/scales.R +++ b/R/scales.R @@ -466,7 +466,6 @@ scale_quantile <- function(col, range = 0:1, na_value = 0, na_value = na_value, data = continuous_identity_range(data), get_breaks = quantile_breaks(probs), - col_label = col_label, col_label = as_labeller(col_label), legend = legend ) diff --git a/tests/testthat/test-scale.R b/tests/testthat/test-scale.R new file mode 100644 index 0000000..6a44cd0 --- /dev/null +++ b/tests/testthat/test-scale.R @@ -0,0 +1,14 @@ +test_that("scale_quantile works", { + expect_equal( + compile(scale_quantile(foo, range = 0:1, data = 0:1, probs = seq.int(0, 1, 0.2))), + list( + scale_type = "threshold", + legend = TRUE, + col = "foo", + na_value = 0, + domain = c(0.2, 0.4, 0.6, 0.8), + range = c(0, 0.25, 0.5, 0.75, 1), + scale_by = "foo" + ) + ) +})