Merge pull request #59926 from nyalldawson/thin_xml

troopa81 · web-flow · commit 3e0b74418db3 · 2024-12-17T11:17:30.000+01:00
Don't write unnecessary attribute to XML when saving point cloud layers
diff --git a/src/core/pointcloud/qgspointcloudrenderer.cpp b/src/core/pointcloud/qgspointcloudrenderer.cpp
@@ -260,7 +260,8 @@ void QgsPointCloudRenderer::saveCommonProperties( QDomElement &element, const Qg
   element.setAttribute( QStringLiteral( "horizontalTriangleFilterThreshold" ), qgsDoubleToString( mHorizontalTriangleFilterThreshold ) );
   element.setAttribute( QStringLiteral( "horizontalTriangleFilterUnit" ), QgsUnitTypes::encodeUnit( mHorizontalTriangleFilterUnit ) );
 
-  element.setAttribute( QStringLiteral( "showLabels" ), QString::number( mShowLabels ) );
+  if ( mShowLabels )
+    element.setAttribute( QStringLiteral( "showLabels" ), QStringLiteral( "1" ) );
   if ( mLabelTextFormat.isValid() )
   {
     QDomDocument doc = element.ownerDocument();

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,8 @@ void QgsPointCloudRenderer::saveCommonProperties( QDomElement &element, const Qg`
`260`	`260`	`element.setAttribute( QStringLiteral( "horizontalTriangleFilterThreshold" ), qgsDoubleToString( mHorizontalTriangleFilterThreshold ) );`
`261`	`261`	`element.setAttribute( QStringLiteral( "horizontalTriangleFilterUnit" ), QgsUnitTypes::encodeUnit( mHorizontalTriangleFilterUnit ) );`
`262`	`262`
`263`		`- element.setAttribute( QStringLiteral( "showLabels" ), QString::number( mShowLabels ) );`
	`263`	`+ if ( mShowLabels )`
	`264`	`+ element.setAttribute( QStringLiteral( "showLabels" ), QStringLiteral( "1" ) );`
`264`	`265`	`if ( mLabelTextFormat.isValid() )`
`265`	`266`	`{`
`266`	`267`	`QDomDocument doc = element.ownerDocument();`