Collapse OR nodes into IN #59440
Merged
Collapse OR nodes into IN #59440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes qgis#43992 but also implements an optimization of OR chained nodes by turning them into IN conditions when possible. On behalf of: Faunalia
elpaso
added
Expressions
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
troopa81
reviewed
Nov 14, 2024
troopa81
approved these changes
Nov 14, 2024
|
@troopa81 thank you for your review and suggestions, much appreciated! |
elpaso
added a commit
to elpaso/QGIS
that referenced
this pull request
Nov 14, 2024
Manual and partial backport of qgis#59440 Limited to the changeset that fixes qgis#43992, the other changes are optimizations that are not suitable for backports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43992 but also implements
an optimization of OR chained nodes
by turning them into IN conditions
when possible.
On behalf of: Faunalia