From 09c97eeb43d60c3dbe5854ec10a070c4d70002b7 Mon Sep 17 00:00:00 2001
From: qingxinwu <6334674+qingxinwu@users.noreply.github.com>
Date: Mon, 28 Aug 2023 15:21:54 -0400
Subject: [PATCH] Fix the wrong service-worker mode. (#733)

---
 spec.bs | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/spec.bs b/spec.bs
index 6776590d6..34ccda925 100644
--- a/spec.bs
+++ b/spec.bs
@@ -349,8 +349,6 @@ To <dfn>check interest group permissions</dfn> given an [=origin=]
   ::  «`Accept`: `application/json`»
   :   [=request/client=]
   ::  `null`
-  :   [=request/service-workers mode=]
-  ::  "`none`"
   :   [=request/origin=]
   ::  |frameOrigin|
   :   [=request/mode=]
@@ -361,6 +359,9 @@ To <dfn>check interest group permissions</dfn> given an [=origin=]
   ::  "`omit`"
   :   [=request/redirect mode=]
   :: "`error`"
+
+  Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
+    service worker interceptions, despite not having to set the service workers mode.
 1. Let |resource| be null.
 1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
   [=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|
@@ -1532,8 +1533,6 @@ To <dfn>fetch script</dfn> given a [=URL=] |url|:
     ::  «`Accept`: `text/javascript`»
     :   [=request/client=]
     ::  `null`
-    :   [=request/service-workers mode=]
-    ::  "`none`"
     :   [=request/mode=]
     ::  "`no-cors`"
     :   [=request/referrer=]
@@ -1542,6 +1541,9 @@ To <dfn>fetch script</dfn> given a [=URL=] |url|:
     ::  "`omit`"
     :   [=request/redirect mode=]
     :: "`error`"
+
+    Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
+      service worker interceptions, despite not having to set the service workers mode.
   1. Let |script| be null.
   1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
     [=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|
@@ -1563,8 +1565,6 @@ To <dfn>fetch WebAssembly</dfn> given a [=URL=] |url|:
     ::  «`Accept`: `application/wasm`»
     :   [=request/client=]
     ::  `null`
-    :   [=request/service-workers mode=]
-    ::  "`none`"
     :   [=request/mode=]
     ::  "`no-cors`"
     :   [=request/referrer=]
@@ -1573,6 +1573,9 @@ To <dfn>fetch WebAssembly</dfn> given a [=URL=] |url|:
     ::  "`omit`"
     :   [=request/redirect mode=]
     :: "`error`"
+
+    Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
+      service worker interceptions, despite not having to set the service workers mode.
   1. Let |moduleObject| be null.
   1. [=Fetch=] |request| with [=fetch/processResponseConsumeBody=] set to the following steps given
     a [=response=] |response| and null, failure, or a [=byte sequence=] |responseBody|:
@@ -1602,8 +1605,6 @@ To <dfn>fetch trusted signals</dfn> given a [=URL=] |url|, and a [=boolean=] |is
     ::  «`Accept`: `application/json`»
     :   [=request/client=]
     ::  `null`
-    :   [=request/service-workers mode=]
-    ::  "`none`"
     :   [=request/mode=]
     ::  "`no-cors`"
     :   [=request/referrer=]
@@ -1612,6 +1613,9 @@ To <dfn>fetch trusted signals</dfn> given a [=URL=] |url|, and a [=boolean=] |is
     ::  "`omit`"
     :   [=request/redirect mode=]
     :: "`error`"
+
+    Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
+      service worker interceptions, despite not having to set the service workers mode.
   1. Let |signals| be null.
   1. Let |dataVersion| be null.
   1. Let |formatVersion| be null.
@@ -2628,8 +2632,6 @@ The <dfn for=Navigator method>updateAdInterestGroups()</dfn> method steps are:
       ::  «`Accept`: `application/json`»
       :   [=request/client=]
       ::  `null`
-      :   [=request/service-workers mode=]
-      ::  "`none`"
       :   [=request/mode=]
       ::  "`no-cors`"
       :   [=request/referrer=]
@@ -2638,6 +2640,9 @@ The <dfn for=Navigator method>updateAdInterestGroups()</dfn> method steps are:
       ::  "`omit`"
       :   [=request/redirect mode=]
       :: "`error`"
+
+      Issue: One of the side-effects of a `null` client for this subresource request is it neuters
+        all service worker interceptions, despite not having to set the service workers mode.
     1. Let |update| be null.
     1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
       [=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|