We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It seems to me the definition of custom_data_map_func in custom_feature_map.ipynb does not correspond to the mathematical expression.
coeff = x[0] if len(x) == 1 else functools.reduce(lambda m, n: m * n, np.pi - x)
gives the default function, when it should be coeff = x[0] if len(x) == 1 else functools.reduce(lambda m, n: m * n, np.sin(np.pi - x))
coeff = x[0] if len(x) == 1 else functools.reduce(lambda m, n: m * n, np.sin(np.pi - x))
to be consistent with the text.
The text was updated successfully, but these errors were encountered:
fixed issue: Missing invocation of np.sin in custom_feature_map.ipynb q…
897d9bf
…iskit-community#133
No branches or pull requests
It seems to me the definition of custom_data_map_func in custom_feature_map.ipynb
does not correspond to the mathematical expression.
coeff = x[0] if len(x) == 1 else functools.reduce(lambda m, n: m * n, np.pi - x)
gives the default function, when it should be
coeff = x[0] if len(x) == 1 else functools.reduce(lambda m, n: m * n, np.sin(np.pi - x))
to be consistent with the text.
The text was updated successfully, but these errors were encountered: